mt76: mt7663: introduce 802.11 PS support in sta mode

Enable 802.11 power-save support available in mt7663 firmware

Co-developed-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Felix Fietkau <nbd@nbd.name>

diff --git a/drivers/net/wireless/mediatek/mt76/mt76.h b/drivers/net/wireless/mediatek/mt76/mt76.h
index 577465c0182788ab89a2b888ef1d2e8789aa78b0..6106dc4fea44aa9b43ec3b988f100240d2db43f0 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt76.h
+++ b/drivers/net/wireless/mediatek/mt76/mt76.h
@@ -286,6 +286,7 @@ enum {
        MT76_REMOVED,
        MT76_READING_STATS,
        MT76_STATE_POWER_OFF,
+       MT76_STATE_PS,
 };
 
 struct mt76_hw_cap {

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
index 9d9f73b4561e4a042fcda2e75e5f7ea18b92d86a..6fc3f5aa94c0992332e365453a722049ee5c9c08 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
@@ -323,6 +323,8 @@ int mt7615_register_ext_phy(struct mt7615_dev *dev)
        INIT_DELAYED_WORK(&phy->scan_work, mt7615_scan_work);
        skb_queue_head_init(&phy->scan_event_list);
 
+       INIT_WORK(&dev->phy.ps_work, mt7615_ps_work);
+
        mt7615_cap_dbdc_enable(dev);
        mphy = mt76_alloc_phy(&dev->mt76, sizeof(*phy), &mt7615_ops);
        if (!mphy)
@@ -386,7 +388,9 @@ void mt7615_init_device(struct mt7615_dev *dev)
        INIT_LIST_HEAD(&dev->sta_poll_list);
        spin_lock_init(&dev->sta_poll_lock);
        init_waitqueue_head(&dev->reset_wait);
+
        INIT_WORK(&dev->reset_work, mt7615_mac_reset_work);
+       INIT_WORK(&dev->phy.ps_work, mt7615_ps_work);
 
        mt7615_init_wiphy(hw);
        dev->mphy.sband_2g.sband.ht_cap.cap |= IEEE80211_HT_CAP_LDPC_CODING;

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c
index b6e92bb3b1280c9d555f3030bfebc1d99ec79696..3dab07d3eb1d3189a6e3ee7a1ffe29a5ba35606d 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c
@@ -605,8 +605,11 @@ int mt7615_mac_write_txwi(struct mt7615_dev *dev, __le32 *txwi,
        }
 
        if (!ieee80211_is_beacon(fc)) {
-               val = MT_TXD5_TX_STATUS_HOST | MT_TXD5_SW_POWER_MGMT |
-                     FIELD_PREP(MT_TXD5_PID, pid);
+               struct ieee80211_hw *hw = mt76_hw(dev);
+
+               val = MT_TXD5_TX_STATUS_HOST | FIELD_PREP(MT_TXD5_PID, pid);
+               if (!ieee80211_hw_check(hw, SUPPORTS_PS))
+                       val |= MT_TXD5_SW_POWER_MGMT;
                txwi[5] = cpu_to_le32(val);
        } else {
                txwi[5] = 0;

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/main.c b/drivers/net/wireless/mediatek/mt76/mt7615/main.c
index f7fc2185da3be694f6f6e52c5a1d4e845c79dabb..8f8ad632d6bae76a7f6ed40d24c7762553754906 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7615/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/main.c
@@ -71,6 +71,7 @@ static void mt7615_stop(struct ieee80211_hw *hw)
        struct mt7615_phy *phy = mt7615_hw_phy(hw);
 
        cancel_delayed_work_sync(&phy->mac_work);
+       cancel_work_sync(&phy->ps_work);
 
        mutex_lock(&dev->mt76.mutex);
 
@@ -362,6 +363,20 @@ static int mt7615_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd,
        return mt7615_mac_wtbl_set_key(dev, wcid, key, cmd);
 }
 
+void mt7615_ps_work(struct work_struct *work)
+{
+       struct mt7615_phy *phy;
+
+       phy = (struct mt7615_phy *)container_of(work, struct mt7615_phy,
+                                               ps_work);
+
+       mutex_lock(&phy->dev->mt76.mutex);
+       ieee80211_iterate_active_interfaces(phy->mt76->hw,
+                                           IEEE80211_IFACE_ITER_RESUME_ALL,
+                                           m7615_mcu_set_ps_iter, phy);
+       mutex_unlock(&phy->dev->mt76.mutex);
+}
+
 static int mt7615_config(struct ieee80211_hw *hw, u32 changed)
 {
        struct mt7615_dev *dev = mt7615_hw_dev(hw);
@@ -387,6 +402,14 @@ static int mt7615_config(struct ieee80211_hw *hw, u32 changed)
                mt76_wr(dev, MT_WF_RFCR(band), phy->rxfilter);
        }
 
+       if (changed & IEEE80211_CONF_CHANGE_PS) {
+               if (hw->conf.flags & IEEE80211_CONF_PS)
+                       set_bit(MT76_STATE_PS, &phy->mt76->state);
+               else
+                       clear_bit(MT76_STATE_PS, &phy->mt76->state);
+               ieee80211_queue_work(hw, &phy->ps_work);
+       }
+
        mutex_unlock(&dev->mt76.mutex);
 
        return ret;

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
index 530d6302b53abc0643fd1b34a3bde481fe8b7e83..74cbb975be7568bfe6bcf5dfea99db5a3991359a 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
@@ -2586,6 +2586,27 @@ int mt7615_mcu_set_sku_en(struct mt7615_phy *phy, bool enable)
                                   sizeof(req), true);
 }
 
+void m7615_mcu_set_ps_iter(void *priv, u8 *mac, struct ieee80211_vif *vif)
+{
+       struct mt7615_vif *mvif = (struct mt7615_vif *)vif->drv_priv;
+       struct mt7615_phy *phy = priv;
+       struct mt76_phy *mphy = phy->mt76;
+       struct {
+               u8 bss_idx;
+               u8 ps_state; /* 0: device awake
+                             * 1: static power save
+                             * 2: dynamic power saving
+                             */
+       } req = {
+               .bss_idx = mvif->idx,
+               .ps_state = test_bit(MT76_STATE_PS, &mphy->state) ? 2 : 0,
+       };
+
+       if (vif->type == NL80211_IFTYPE_STATION)
+               __mt76_mcu_send_msg(&phy->dev->mt76,  MCU_CMD_SET_PS_PROFILE,
+                                   &req, sizeof(req), false);
+}
+
 int mt7615_mcu_set_channel_domain(struct mt7615_phy *phy)
 {
        struct mt76_phy *mphy = phy->mt76;

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.h b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.h
index dff3f3632fafb5ec188553c03960cee22225f875..5440f24a834ae7ded35e08e6b61b05e9c82982d0 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.h
@@ -411,6 +411,7 @@ struct mt7615_mcu_bss_event {
 /* offload mcu commands */
 enum {
        MCU_CMD_START_HW_SCAN = MCU_CE_PREFIX | 0x03,
+       MCU_CMD_SET_PS_PROFILE = MCU_CE_PREFIX | 0x05,
        MCU_CMD_SET_CHAN_DOMAIN = MCU_CE_PREFIX | 0x0f,
        MCU_CMD_CANCEL_HW_SCAN = MCU_CE_PREFIX | 0x1b,
        MCU_CMD_SCHED_SCAN_ENABLE = MCU_CE_PREFIX | 0x61,

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mt7615.h b/drivers/net/wireless/mediatek/mt76/mt7615/mt7615.h
index 2bc77a0478a959e91475179414282e75125f7db2..c9533282e7e3f6d23cb76eecbb2939a549f56b7d 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mt7615.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mt7615.h
@@ -197,6 +197,8 @@ struct mt7615_phy {
 
        struct sk_buff_head scan_event_list;
        struct delayed_work scan_work;
+
+       struct work_struct ps_work;
 };
 
 #define mt7615_mcu_add_tx_ba(dev, ...) (dev)->mcu_ops->add_tx_ba((dev), __VA_ARGS__)
@@ -423,6 +425,7 @@ static inline bool mt7615_firmware_offload(struct mt7615_dev *dev)
 }
 
 void mt7615_scan_work(struct work_struct *work);
+void mt7615_ps_work(struct work_struct *work);
 void mt7615_init_txpower(struct mt7615_dev *dev,
                         struct ieee80211_supported_band *sband);
 void mt7615_phy_init(struct mt7615_dev *dev);
@@ -508,6 +511,7 @@ int mt7615_mcu_set_radar_th(struct mt7615_dev *dev, int index,
 int mt7615_mcu_set_sku_en(struct mt7615_phy *phy, bool enable);
 int mt7615_mcu_apply_rx_dcoc(struct mt7615_phy *phy);
 int mt7615_mcu_apply_tx_dpd(struct mt7615_phy *phy);
+void m7615_mcu_set_ps_iter(void *priv, u8 *mac, struct ieee80211_vif *vif);
 int mt7615_dfs_init_radar_detector(struct mt7615_phy *phy);
 
 int mt7615_init_debugfs(struct mt7615_dev *dev);

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c b/drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c
index 3a8dd334b53e9f716909ef5862dc84f8617ddbc9..cd3ccafa7d11d3fae2c33c8b0d4e810c933827dd 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/pci_init.c
@@ -16,6 +16,7 @@ static void mt7615_init_work(struct work_struct *work)
 {
        struct mt7615_dev *dev = container_of(work, struct mt7615_dev,
                                              mcu_work);
+       struct ieee80211_hw *hw = mt76_hw(dev);
 
        if (mt7615_mcu_init(dev))
                return;
@@ -25,8 +26,11 @@ static void mt7615_init_work(struct work_struct *work)
        mt7615_phy_init(dev);
        mt7615_mcu_del_wtbl_all(dev);
 
-       if (!mt7615_firmware_offload(dev)) {
-               struct wiphy *wiphy = mt76_hw(dev)->wiphy;
+       if (mt7615_firmware_offload(dev)) {
+               ieee80211_hw_set(hw, SUPPORTS_PS);
+               ieee80211_hw_set(hw, SUPPORTS_DYNAMIC_PS);
+       } else {
+               struct wiphy *wiphy = hw->wiphy;
 
                dev->ops->hw_scan = NULL;
                dev->ops->cancel_hw_scan = NULL;

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/usb_init.c b/drivers/net/wireless/mediatek/mt76/mt7615/usb_init.c
index a05f0eda21ddc9c0a0f42b92a06ed8e8d787a60f..39642065531fe027320d7eef4c1d856620eb9ce3 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7615/usb_init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/usb_init.c
@@ -119,6 +119,9 @@ int mt7663u_register_device(struct mt7615_dev *dev)
        if (err)
                return err;
 
+       ieee80211_hw_set(hw, SUPPORTS_PS);
+       ieee80211_hw_set(hw, SUPPORTS_DYNAMIC_PS);
+
        hw->extra_tx_headroom += MT_USB_HDR_SIZE + MT_USB_TXD_SIZE;
        /* check hw sg support in order to enable AMSDU */
        hw->max_tx_fragments = dev->mt76.usb.sg_en ? MT_HW_TXP_MAX_BUF_NUM : 1;