wifi: wireless: avoid strlen() in cfg80211_michael_mic_failure()
authorDmitry Antipov <dmantipov@yandex.ru>
Wed, 10 Jan 2024 05:42:06 +0000 (08:42 +0300)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 26 Jan 2024 08:28:26 +0000 (09:28 +0100)
In 'cfg80211_michael_mic_failure()', avoid extra call to 'strlen()'
by using the value returned by 'sprintf()'. Compile tested only.

Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
Link: https://msgid.link/20240110054246.371651-1-dmantipov@yandex.ru
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/wireless/mlme.c

index f635a8b6ca2ec07a9617361aa5785743e4b5df08..43ba7891e2a3ed2273cb2b7b08be9c1baef7b803 100644 (file)
@@ -241,12 +241,12 @@ void cfg80211_michael_mic_failure(struct net_device *dev, const u8 *addr,
        char *buf = kmalloc(128, gfp);
 
        if (buf) {
-               sprintf(buf, "MLME-MICHAELMICFAILURE.indication("
-                       "keyid=%d %scast addr=%pM)", key_id,
-                       key_type == NL80211_KEYTYPE_GROUP ? "broad" : "uni",
-                       addr);
                memset(&wrqu, 0, sizeof(wrqu));
-               wrqu.data.length = strlen(buf);
+               wrqu.data.length =
+                       sprintf(buf, "MLME-MICHAELMICFAILURE."
+                               "indication(keyid=%d %scast addr=%pM)",
+                               key_id, key_type == NL80211_KEYTYPE_GROUP
+                               ? "broad" : "uni", addr);
                wireless_send_event(dev, IWEVCUSTOM, &wrqu, buf);
                kfree(buf);
        }