ASoC: cros_ec_codec: Reset I2S RX when probing
authorYu-Hsuan Hsu <yuhsuan@chromium.org>
Fri, 15 Jan 2021 07:53:01 +0000 (15:53 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 19 Jan 2021 14:09:23 +0000 (14:09 +0000)
It is not guaranteed that I2S RX is disabled when the kernel booting.
For example, if the kernel crashes while it is enabled, it will keep
enabled until the next time EC reboots. Reset I2S RX when probing to
fix this issue.

Signed-off-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Link: https://lore.kernel.org/r/20210115075301.47995-2-yuhsuan@chromium.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cros_ec_codec.c

index f33a2a9654e76becb7d059b800d7c536c31749d7..c4772f82485a350fb52fe4934e6b7a6b927b61dd 100644 (file)
@@ -1011,6 +1011,18 @@ static int cros_ec_codec_platform_probe(struct platform_device *pdev)
        }
        priv->ec_capabilities = r.capabilities;
 
+       /* Reset EC codec i2s rx. */
+       p.cmd = EC_CODEC_I2S_RX_RESET;
+       ret = send_ec_host_command(priv->ec_device, EC_CMD_EC_CODEC_I2S_RX,
+                                  (uint8_t *)&p, sizeof(p), NULL, 0);
+       if (ret == -ENOPROTOOPT) {
+               dev_info(dev,
+                        "Missing reset command. Please update EC firmware.\n");
+       } else if (ret) {
+               dev_err(dev, "failed to EC_CODEC_I2S_RESET: %d\n", ret);
+               return ret;
+       }
+
        platform_set_drvdata(pdev, priv);
 
        ret = devm_snd_soc_register_component(dev, &i2s_rx_component_driver,