net/mlx5_core: fix an error code
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 11 Jun 2015 08:50:01 +0000 (11:50 +0300)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Jun 2015 22:44:41 +0000 (15:44 -0700)
We return success if mlx5e_alloc_sq_db() fails but we should return an
error code.

Fixes: f62b8bb8f2d3 ('net/mlx5: Extend mlx5_core to support ConnectX-4 Ethernet functionality')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Or Gerlitz <ogerlitz@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c

index 7348c5173aa976f96aed8f0d29e148bb9700054f..075e5175e7795a1244beb76a081b00c0d24c7e8c 100644 (file)
@@ -525,7 +525,8 @@ static int mlx5e_create_sq(struct mlx5e_channel *c,
        sq->uar_map     = sq->uar.map;
        sq->bf_buf_size = (1 << MLX5_CAP_GEN(mdev, log_bf_reg_size)) / 2;
 
-       if (mlx5e_alloc_sq_db(sq, cpu_to_node(c->cpu)))
+       err = mlx5e_alloc_sq_db(sq, cpu_to_node(c->cpu));
+       if (err)
                goto err_sq_wq_destroy;
 
        sq->txq = netdev_get_tx_queue(priv->netdev,