drm/msm/dp: set safe_to_exit_level before printing it
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mon, 2 Dec 2024 10:06:31 +0000 (12:06 +0200)
committerAbhinav Kumar <quic_abhinavk@quicinc.com>
Tue, 3 Dec 2024 02:37:35 +0000 (18:37 -0800)
Rather than printing random garbage from stack and pretending that it is
the default safe_to_exit_level, set the variable beforehand.

Fixes: d13e36d7d222 ("drm/msm/dp: add audio support for Display Port on MSM")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202411081748.0PPL9MIj-lkp@intel.com/
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/626804/
Link: https://lore.kernel.org/r/20241202-fd-dp-audio-fixup-v2-1-d9187ea96dad@linaro.org
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
drivers/gpu/drm/msm/dp/dp_audio.c

index 74e01a5dd4195d5e0e04250663886f1116f25711..5cbb11986460d1e4ed1890bdf66d0913e013083c 100644 (file)
@@ -329,10 +329,10 @@ static void msm_dp_audio_safe_to_exit_level(struct msm_dp_audio_private *audio)
                safe_to_exit_level = 5;
                break;
        default:
+               safe_to_exit_level = 14;
                drm_dbg_dp(audio->drm_dev,
                                "setting the default safe_to_exit_level = %u\n",
                                safe_to_exit_level);
-               safe_to_exit_level = 14;
                break;
        }