proc: Reduce cache miss in sctp_snmp_seq_show
authorJia He <hejianet@gmail.com>
Fri, 30 Sep 2016 03:29:01 +0000 (11:29 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 30 Sep 2016 05:50:44 +0000 (01:50 -0400)
This is to use the generic interfaces snmp_get_cpu_field{,64}_batch to
aggregate the data by going through all the items of each cpu sequentially.

Signed-off-by: Jia He <hejianet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/proc.c

index ef8ba77a5beace906ac3e83b3c0824a2134e6a63..09e16c2b5c179d4dd55bf0769b3d4792e9ec96a4 100644 (file)
@@ -73,13 +73,17 @@ static const struct snmp_mib sctp_snmp_list[] = {
 /* Display sctp snmp mib statistics(/proc/net/sctp/snmp). */
 static int sctp_snmp_seq_show(struct seq_file *seq, void *v)
 {
+       unsigned long buff[SCTP_MIB_MAX];
        struct net *net = seq->private;
        int i;
 
+       memset(buff, 0, sizeof(unsigned long) * SCTP_MIB_MAX);
+
+       snmp_get_cpu_field_batch(buff, sctp_snmp_list,
+                                net->sctp.sctp_statistics);
        for (i = 0; sctp_snmp_list[i].name != NULL; i++)
                seq_printf(seq, "%-32s\t%ld\n", sctp_snmp_list[i].name,
-                          snmp_fold_field(net->sctp.sctp_statistics,
-                                     sctp_snmp_list[i].entry));
+                                               buff[i]);
 
        return 0;
 }