ASoC: wm8985: Remove use of i2c_match_id()
authorAndrew Davis <afd@ti.com>
Tue, 3 Dec 2024 20:00:01 +0000 (14:00 -0600)
committerMark Brown <broonie@kernel.org>
Mon, 9 Dec 2024 13:12:46 +0000 (13:12 +0000)
The function i2c_match_id() is used to fetch the matching ID from
the i2c_device_id table. This is often used to then retrieve the
matching driver_data. This can be done in one step with the helper
i2c_get_match_data().

This helper has a couple other benefits:
 * It doesn't need the i2c_device_id passed in so we do not need
   to have that forward declared, allowing us to remove those or
   move the i2c_device_id table down to its more natural spot
   with the other module info.
 * It also checks for device match data, which allows for OF and
   ACPI based probing. That means we do not have to manually check
   those first and can remove those checks.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://patch.msgid.link/20241203200001.197295-21-afd@ti.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm8985.c

index 8606e0752a6043bc1934a1b08869eae71e82d180..da00db5b017264172b4f710a4c12dfdebc2f12e8 100644 (file)
@@ -1166,12 +1166,10 @@ static struct spi_driver wm8985_spi_driver = {
 #endif
 
 #if IS_ENABLED(CONFIG_I2C)
-static const struct i2c_device_id wm8985_i2c_id[];
 
 static int wm8985_i2c_probe(struct i2c_client *i2c)
 {
        struct wm8985_priv *wm8985;
-       const struct i2c_device_id *id = i2c_match_id(wm8985_i2c_id, i2c);
        int ret;
 
        wm8985 = devm_kzalloc(&i2c->dev, sizeof *wm8985, GFP_KERNEL);
@@ -1180,7 +1178,7 @@ static int wm8985_i2c_probe(struct i2c_client *i2c)
 
        i2c_set_clientdata(i2c, wm8985);
 
-       wm8985->dev_type = id->driver_data;
+       wm8985->dev_type = (uintptr_t)i2c_get_match_data(i2c);
 
        wm8985->regmap = devm_regmap_init_i2c(i2c, &wm8985_regmap);
        if (IS_ERR(wm8985->regmap)) {