media: async: Warn on attept to create an ancillary link to a non-subdev

Warn if a lens or a flash async sub-device is bound to a non-sub-device
notifier. This isn't meaningful and unlikely to happen in practice but
print a warning as we nevertheless won't consider this an error.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/drivers/media/v4l2-core/v4l2-async.c b/drivers/media/v4l2-core/v4l2-async.c
index c477723c07bf8e1cfe96659041ceafecd966ba6a..81a9b5473969d29b058375bb544382fce504a1c9 100644 (file)
--- a/drivers/media/v4l2-core/v4l2-async.c
+++ b/drivers/media/v4l2-core/v4l2-async.c
@@ -323,8 +323,12 @@ static int v4l2_async_create_ancillary_links(struct v4l2_async_notifier *n,
            sd->entity.function != MEDIA_ENT_F_FLASH)
                return 0;
 
-       if (!n->sd)
+       if (!n->sd) {
+               dev_warn(notifier_dev(n),
+                        "not a sub-device notifier, not creating an ancillary link for %s!\n",
+                        dev_name(sd->dev));
                return 0;
+       }
 
        link = media_create_ancillary_link(&n->sd->entity, &sd->entity);