tty: goldfish: drop unneeded temporary variables

We can pass 'buf' directly to goldfish_tty_rw() using simple (unsigned
long) cast. There is no need to obfuscate the code by another variable
with double casts.

Signed-off-by: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20231121092258.9334-9-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
index 4591f940b7a1511a807dc31141d8d4d179bd0d03..dccf6c6c69c6e980f0253af514ba416e03fac0f1 100644 (file)
--- a/drivers/tty/goldfish.c
+++ b/drivers/tty/goldfish.c
@@ -128,16 +128,14 @@ static void goldfish_tty_rw(struct goldfish_tty *qtty,
 static void goldfish_tty_do_write(int line, const u8 *buf, unsigned int count)
 {
        struct goldfish_tty *qtty = &goldfish_ttys[line];
-       unsigned long address = (unsigned long)(void *)buf;
 
-       goldfish_tty_rw(qtty, address, count, 1);
+       goldfish_tty_rw(qtty, (unsigned long)buf, count, 1);
 }
 
 static irqreturn_t goldfish_tty_interrupt(int irq, void *dev_id)
 {
        struct goldfish_tty *qtty = dev_id;
        void __iomem *base = qtty->base;
-       unsigned long address;
        unsigned char *buf;
        u32 count;
 
@@ -147,8 +145,7 @@ static irqreturn_t goldfish_tty_interrupt(int irq, void *dev_id)
 
        count = tty_prepare_flip_string(&qtty->port, &buf, count);
 
-       address = (unsigned long)(void *)buf;
-       goldfish_tty_rw(qtty, address, count, 0);
+       goldfish_tty_rw(qtty, (unsigned long)buf, count, 0);
 
        tty_flip_buffer_push(&qtty->port);
        return IRQ_HANDLED;