usb: cdns3: add quirk for enable runtime pm by default

Some vendors (eg: NXP) may want to enable runtime pm by default for
power saving, add one quirk for it.

Reviewed-by: Jun Li <jun.li@nxp.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>

diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
index f2dedce3a40e4ba159bc473383c116f02a1fda77..54d841aa626f81cda7d7e62c677df7ef54433ba8 100644 (file)
--- a/drivers/usb/cdns3/core.c
+++ b/drivers/usb/cdns3/core.c
@@ -559,7 +559,8 @@ static int cdns3_probe(struct platform_device *pdev)
        device_set_wakeup_capable(dev, true);
        pm_runtime_set_active(dev);
        pm_runtime_enable(dev);
-       pm_runtime_forbid(dev);
+       if (!(cdns->pdata->quirks & CDNS3_DEFAULT_PM_RUNTIME_ALLOW))
+               pm_runtime_forbid(dev);
 
        /*
         * The controller needs less time between bus and controller suspend,

diff --git a/drivers/usb/cdns3/core.h b/drivers/usb/cdns3/core.h
index 8a40d53d5edebda888560be21b0bea769169804a..3176f924293a188b922be6271435627478d8f603 100644 (file)
--- a/drivers/usb/cdns3/core.h
+++ b/drivers/usb/cdns3/core.h
@@ -42,6 +42,8 @@ struct cdns3_role_driver {
 struct cdns3_platform_data {
        int (*platform_suspend)(struct device *dev,
                        bool suspend, bool wakeup);
+       unsigned long quirks;
+#define CDNS3_DEFAULT_PM_RUNTIME_ALLOW BIT(0)
 };
 
 /**
@@ -73,6 +75,7 @@ struct cdns3_platform_data {
  * @wakeup_pending: wakeup interrupt pending
  * @pdata: platform data from glue layer
  * @lock: spinlock structure
+ * @xhci_plat_data: xhci private data structure pointer
  */
 struct cdns3 {
        struct device                   *dev;
@@ -106,6 +109,7 @@ struct cdns3 {
        bool                            wakeup_pending;
        struct cdns3_platform_data      *pdata;
        spinlock_t                      lock;
+       struct xhci_plat_priv           *xhci_plat_data;
 };
 
 int cdns3_hw_role_switch(struct cdns3 *cdns);

diff --git a/drivers/usb/cdns3/host.c b/drivers/usb/cdns3/host.c
index b273ae2231d50588e7bbcb2cbcdd12c527a308a4..08103785a17aab11b48b1f87a2fe316ca8ae633d 100644 (file)
--- a/drivers/usb/cdns3/host.c
+++ b/drivers/usb/cdns3/host.c
@@ -52,15 +52,25 @@ static int __cdns3_host_init(struct cdns3 *cdns)
                goto err1;
        }
 
-       ret = platform_device_add_data(xhci, &xhci_plat_cdns3_xhci,
+       cdns->xhci_plat_data = kmemdup(&xhci_plat_cdns3_xhci,
+                       sizeof(struct xhci_plat_priv), GFP_KERNEL);
+       if (!cdns->xhci_plat_data) {
+               ret = -ENOMEM;
+               goto err1;
+       }
+
+       if (cdns->pdata->quirks & CDNS3_DEFAULT_PM_RUNTIME_ALLOW)
+               cdns->xhci_plat_data->quirks |= XHCI_DEFAULT_PM_RUNTIME_ALLOW;
+
+       ret = platform_device_add_data(xhci, cdns->xhci_plat_data,
                        sizeof(struct xhci_plat_priv));
        if (ret)
-               goto err1;
+               goto free_memory;
 
        ret = platform_device_add(xhci);
        if (ret) {
                dev_err(cdns->dev, "failed to register xHCI device\n");
-               goto err1;
+               goto free_memory;
        }
 
        /* Glue needs to access xHCI region register for Power management */
@@ -69,6 +79,9 @@ static int __cdns3_host_init(struct cdns3 *cdns)
                cdns->xhci_regs = hcd->regs;
 
        return 0;
+
+free_memory:
+       kfree(cdns->xhci_plat_data);
 err1:
        platform_device_put(xhci);
        return ret;
@@ -102,6 +115,7 @@ int xhci_cdns3_suspend_quirk(struct usb_hcd *hcd)
 
 static void cdns3_host_exit(struct cdns3 *cdns)
 {
+       kfree(cdns->xhci_plat_data);
        platform_device_unregister(cdns->host_dev);
        cdns->host_dev = NULL;
        cdns3_drd_host_off(cdns);