drm/i915/params: use generics for parameter dup
authorJani Nikula <jani.nikula@intel.com>
Wed, 18 Jan 2023 15:17:58 +0000 (17:17 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 25 Jan 2023 14:25:33 +0000 (16:25 +0200)
Replace the __builtin_strcmp() if ladder with generics.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230118151800.3669913-2-jani.nikula@intel.com
drivers/gpu/drm/i915/i915_params.c

index 6482e878f31efd829d78cdcb77bd1d22421af19a..f9d92d0ab2b58ca6c50278caddaa45394d16632f 100644 (file)
@@ -274,16 +274,24 @@ void i915_params_dump(const struct i915_params *params, struct drm_printer *p)
 #undef PRINT
 }
 
-static __always_inline void dup_param(const char *type, void *x)
+static void _param_dup_charp(char **valp)
 {
-       if (!__builtin_strcmp(type, "char *"))
-               *(void **)x = kstrdup(*(void **)x, GFP_ATOMIC);
+       *valp = kstrdup(*valp, GFP_ATOMIC);
 }
 
+static void _param_nop(void *valp)
+{
+}
+
+#define _param_dup(valp)                               \
+       _Generic(valp,                                  \
+                char **: _param_dup_charp,             \
+                default: _param_nop)(valp)
+
 void i915_params_copy(struct i915_params *dest, const struct i915_params *src)
 {
        *dest = *src;
-#define DUP(T, x, ...) dup_param(#T, &dest->x);
+#define DUP(T, x, ...) _param_dup(&dest->x);
        I915_PARAMS_FOR_EACH(DUP);
 #undef DUP
 }