dlm: return -ENOMEM if ls_recover_buf fails
authorAlexander Aring <aahringo@redhat.com>
Tue, 23 Apr 2024 12:52:31 +0000 (08:52 -0400)
committerDavid Teigland <teigland@redhat.com>
Tue, 23 Apr 2024 21:08:55 +0000 (16:08 -0500)
This patch fixes to return -ENOMEM in case of an allocation failure that
was forgotten to change in commit 6c648035cbe7 ("dlm: switch to use
rhashtable for rsbs").

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202404200536.jGi6052v-lkp@intel.com/
Fixes: 6c648035cbe7 ("dlm: switch to use rhashtable for rsbs")
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Signed-off-by: David Teigland <teigland@redhat.com>
fs/dlm/lockspace.c

index ed23787271b11af935202bbbfb9ab25d86ee2db0..475ab4370ddae3e3728f76aa80c9e07b0fa9b211 100644 (file)
@@ -482,8 +482,10 @@ static int new_lockspace(const char *name, const char *cluster,
         * might send less.
         */
        ls->ls_recover_buf = kmalloc(DLM_MAX_SOCKET_BUFSIZE, GFP_NOFS);
-       if (!ls->ls_recover_buf)
+       if (!ls->ls_recover_buf) {
+               error = -ENOMEM;
                goto out_lkbidr;
+       }
 
        ls->ls_slot = 0;
        ls->ls_num_slots = 0;