sched: Don't report SCHED_FLAG_SUGOV in sched_getattr()
authorQuentin Perret <qperret@google.com>
Tue, 27 Jul 2021 10:11:02 +0000 (11:11 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Wed, 4 Aug 2021 13:16:44 +0000 (15:16 +0200)
SCHED_FLAG_SUGOV is supposed to be a kernel-only flag that userspace
cannot interact with. However, sched_getattr() currently reports it
in sched_flags if called on a sugov worker even though it is not
actually defined in a UAPI header. To avoid this, make sure to
clean-up the sched_flags field in sched_getattr() before returning to
userspace.

Signed-off-by: Quentin Perret <qperret@google.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20210727101103.2729607-3-qperret@google.com
kernel/sched/core.c

index 6c562ad1ad5dbe9b038400efc4998f5f6cda3a35..314f70db3e5cf455ce13e06f9a07384e3642a1a2 100644 (file)
@@ -7530,6 +7530,7 @@ SYSCALL_DEFINE4(sched_getattr, pid_t, pid, struct sched_attr __user *, uattr,
                kattr.sched_priority = p->rt_priority;
        else
                kattr.sched_nice = task_nice(p);
+       kattr.sched_flags &= SCHED_FLAG_ALL;
 
 #ifdef CONFIG_UCLAMP_TASK
        /*