ext4: Add a WARN_ON_ONCE for querying LAST_IN_LEAF instead

We added the documentation in ext4_map_blocks() for usage of
EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF flag. But It's better to add
a WARN_ON_ONCE in case if anyone tries using this flag with CREATE to
avoid a random issue later. Since depth can change with CREATE and it
needs to be re-calculated before using it in there.

Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Link: https://patch.msgid.link/ee6e82a224c50b432df9ce1ce3333c50182d8473.1747677758.git.ritesh.list@gmail.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index c1de66c23dd25638bbd707a45726190867e12d5a..b543a46fc809621081e990adc80a2d4a5330608d 100644 (file)
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -4445,9 +4445,11 @@ out:
         * need to re-calculate the depth as it might have changed due to block
         * allocation.
         */
-       if (flags & EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF)
+       if (flags & EXT4_GET_BLOCKS_QUERY_LAST_IN_LEAF) {
+               WARN_ON_ONCE(flags & EXT4_GET_BLOCKS_CREATE);
                if (!err && ex && (ex == EXT_LAST_EXTENT(path[depth].p_hdr)))
                        map->m_flags |= EXT4_MAP_QUERY_LAST_IN_LEAF;
+       }
 
        ext4_free_ext_path(path);