drm/omap: Change the types of struct omap_video_timings members
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Thu, 22 Sep 2016 11:07:02 +0000 (14:07 +0300)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Wed, 2 Nov 2016 08:48:18 +0000 (10:48 +0200)
omap_video_timings struct have the same members as struct videomode, but
their types are different. As first step change the types of the
omap_video_timings struct members to match their counterpart in
struct videomode to catch any type cast related issues.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
drivers/gpu/drm/omapdrm/dss/dispc.c
drivers/gpu/drm/omapdrm/dss/dpi.c
drivers/gpu/drm/omapdrm/dss/omapdss.h
drivers/gpu/drm/omapdrm/dss/sdi.c

index c3d2a12358fa1afb4c97e7fe025aa5ebb81a6548..8f676b8ac0388489249d465da73869f800009bf3 100644 (file)
@@ -1023,7 +1023,7 @@ static int dsicm_memory_read(struct omap_dss_device *dssdev,
                goto err1;
        }
 
-       size = min(w * h * 3,
+       size = min((u32)w * h * 3,
                        dssdev->panel.timings.hactive *
                        dssdev->panel.timings.vactive * 3);
 
index 83b7a7a2a9e71a020cd2a060875d612a69548316..63d3dc44913ce8df64fdc80033336e94c71f03b5 100644 (file)
@@ -2870,7 +2870,8 @@ int dispc_wb_setup(const struct omap_dss_writeback_info *wi,
                int wbdelay;
 
                wbdelay = min(mgr_timings->vfront_porch +
-                             mgr_timings->vsync_len + mgr_timings->vback_porch, 255);
+                             mgr_timings->vsync_len + mgr_timings->vback_porch,
+                             (u32)255);
 
                /* WBDELAYCOUNT */
                REG_FLD_MOD(DISPC_OVL_ATTRIBUTES2(plane), wbdelay, 7, 0);
@@ -3242,7 +3243,7 @@ void dispc_mgr_set_timings(enum omap_channel channel,
                ht = timings->pixelclock / xtot;
                vt = timings->pixelclock / xtot / ytot;
 
-               DSSDBG("pck %u\n", timings->pixelclock);
+               DSSDBG("pck %lu\n", timings->pixelclock);
                DSSDBG("hsync_len %d hfp %d hbp %d vsw %d vfp %d vbp %d\n",
                        t.hsync_len, t.hfront_porch, t.hback_porch,
                        t.vsync_len, t.vfront_porch, t.vback_porch);
index d653f492cbfd557166c1bc0a5214a4cfe82b9445..8fb40efa65af4e1b7b41bb4edafa8af78e62be43 100644 (file)
@@ -351,7 +351,7 @@ static int dpi_set_mode(struct dpi_data *dpi)
        pck = fck / lck_div / pck_div;
 
        if (pck != t->pixelclock) {
-               DSSWARN("Could not find exact pixel clock. Requested %d Hz, got %lu Hz\n",
+               DSSWARN("Could not find exact pixel clock. Requested %lu Hz, got %lu Hz\n",
                        t->pixelclock, pck);
 
                t->pixelclock = pck;
index 84d34242d5a481a4a7804641bc547845e7481c9f..bd38da3af01f7d2c5559c4adfa456079fff8dead 100644 (file)
@@ -301,23 +301,23 @@ struct omap_dss_dsi_config {
 
 struct omap_video_timings {
        /* Unit: pixels */
-       u16 hactive;
+       u32 hactive;
        /* Unit: pixels */
-       u16 vactive;
+       u32 vactive;
        /* Unit: Hz */
-       u32 pixelclock;
+       unsigned long pixelclock;
        /* Unit: pixel clocks */
-       u16 hsync_len;          /* Horizontal synchronization pulse width */
+       u32 hsync_len;          /* Horizontal synchronization pulse width */
        /* Unit: pixel clocks */
-       u16 hfront_porch;       /* Horizontal front porch */
+       u32 hfront_porch;       /* Horizontal front porch */
        /* Unit: pixel clocks */
-       u16 hback_porch;        /* Horizontal back porch */
+       u32 hback_porch;        /* Horizontal back porch */
        /* Unit: line clocks */
-       u16 vsync_len;          /* Vertical synchronization pulse width */
+       u32 vsync_len;          /* Vertical synchronization pulse width */
        /* Unit: line clocks */
-       u16 vfront_porch;       /* Vertical front porch */
+       u32 vfront_porch;       /* Vertical front porch */
        /* Unit: line clocks */
-       u16 vback_porch;        /* Vertical back porch */
+       u32 vback_porch;        /* Vertical back porch */
 
        enum display_flags flags;
 };
index 3b076329a3acb60313af93d8b789c5457659f24b..c8658f97ab7dca59cca0916bd9d0b76322625e7a 100644 (file)
@@ -162,7 +162,7 @@ static int sdi_display_enable(struct omap_dss_device *dssdev)
        pck = fck / dispc_cinfo.lck_div / dispc_cinfo.pck_div;
 
        if (pck != t->pixelclock) {
-               DSSWARN("Could not find exact pixel clock. Requested %d Hz, got %lu Hz\n",
+               DSSWARN("Could not find exact pixel clock. Requested %lu Hz, got %lu Hz\n",
                        t->pixelclock, pck);
 
                t->pixelclock = pck;