media: common: saa7146: drop vb2_ops_wait_prepare/finish
authorHans Verkuil <hverkuil@xs4all.nl>
Mon, 14 Oct 2024 15:06:35 +0000 (17:06 +0200)
committerHans Verkuil <hverkuil@xs4all.nl>
Mon, 28 Oct 2024 08:20:07 +0000 (09:20 +0100)
Since commit 88785982a19d ("media: vb2: use lock if wait_prepare/finish
are NULL") it is no longer needed to set the wait_prepare/finish
vb2_ops callbacks as long as the lock field in vb2_queue is set.

Since the vb2_ops_wait_prepare/finish callbacks already rely on that field,
we can safely drop these callbacks.

This simplifies the code and this is a step towards the goal of deleting
these callbacks.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/common/saa7146/saa7146_vbi.c
drivers/media/common/saa7146/saa7146_video.c

index bb7d81f7eba624d5baf25b218f9171eb6ae7a5ef..a1854b3dd004b90c3f449df085c28b336bc3abbb 100644 (file)
@@ -407,8 +407,6 @@ const struct vb2_ops vbi_qops = {
        .buf_cleanup    = buf_cleanup,
        .start_streaming = start_streaming,
        .stop_streaming = stop_streaming,
-       .wait_prepare   = vb2_ops_wait_prepare,
-       .wait_finish    = vb2_ops_wait_finish,
 };
 
 /* ------------------------------------------------------------------ */
index 040489e15ea0c32c2646f8c77db83e3ebae10ae5..94e1cd4eaedbf1ed84f30975d0f2505117feac47 100644 (file)
@@ -681,8 +681,6 @@ const struct vb2_ops video_qops = {
        .buf_cleanup    = buf_cleanup,
        .start_streaming = start_streaming,
        .stop_streaming = stop_streaming,
-       .wait_prepare   = vb2_ops_wait_prepare,
-       .wait_finish    = vb2_ops_wait_finish,
 };
 
 /********************************************************************************/