Input: iqs5xx - initialize an uninitialized variable
authorJeff LaBundy <jeff@labundy.com>
Mon, 25 Jan 2021 18:13:14 +0000 (10:13 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 28 Jan 2021 17:48:17 +0000 (09:48 -0800)
If execution jumps to the err_kfree label, error_bl is evaluated
before it is initialized. Fix this by initializing it to zero.

Fixes: 2539da6677b6 ("Input: iqs5xx - preserve bootloader errors")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jeff LaBundy <jeff@labundy.com>
Link: https://lore.kernel.org/r/1611592500-32209-1-git-send-email-jeff@labundy.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/iqs5xx.c

index 05e0c6ff217b4e8f02c44ca3a47c6bd5278e92bb..54f30038dca44420a0dd6bd42012dd4eb77bcdfb 100644 (file)
@@ -852,7 +852,7 @@ static int iqs5xx_fw_file_parse(struct i2c_client *client,
 static int iqs5xx_fw_file_write(struct i2c_client *client, const char *fw_file)
 {
        struct iqs5xx_private *iqs5xx = i2c_get_clientdata(client);
-       int error, error_bl;
+       int error, error_bl = 0;
        u8 *pmap;
 
        if (iqs5xx->bl_status == IQS5XX_BL_STATUS_NONE)