drm/amd/display: Remove BW Allocation from DPIA notification
authorCruise <Cruise.Hung@amd.com>
Thu, 6 Mar 2025 02:17:48 +0000 (10:17 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 7 Apr 2025 19:18:30 +0000 (15:18 -0400)
[Why]
USB4 BW Allocation response will be handled in HPD IRQ.
No need to handle it in DPIA notification callback.

[How]
Remove DP BW allocation response code in DPIA notification.

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Cruise <Cruise.Hung@amd.com>
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dmub/dmub_srv.h
drivers/gpu/drm/amd/display/dmub/src/dmub_srv_stat.c

index 4e0efff92dcafd01591753d0b29a64c0807b5819..80595786341f9f08fe65b300e609d6d20d402c50 100644 (file)
@@ -566,10 +566,6 @@ struct dmub_notification {
                struct aux_reply_data aux_reply;
                enum dp_hpd_status hpd_status;
                enum set_config_status sc_status;
-               /**
-                * DPIA notification command.
-                */
-               struct dmub_rb_cmd_dpia_notification dpia_notification;
                struct dmub_rb_cmd_hpd_sense_notify_data hpd_sense_notify;
        };
 };
index cce887cefc0177f2752a0a1a7f5df5aad69fc681..1c33857aa513ca8e2cf5d794f14bf81dc2275e6c 100644 (file)
@@ -95,23 +95,6 @@ enum dmub_status dmub_srv_stat_get_notification(struct dmub_srv *dmub,
        case DMUB_OUT_CMD__DPIA_NOTIFICATION:
                notify->type = DMUB_NOTIFICATION_DPIA_NOTIFICATION;
                notify->link_index = cmd.dpia_notification.payload.header.instance;
-
-               if (cmd.dpia_notification.payload.header.type == DPIA_NOTIFY__BW_ALLOCATION) {
-
-                       notify->dpia_notification.payload.data.dpia_bw_alloc.estimated_bw =
-                                       cmd.dpia_notification.payload.data.dpia_bw_alloc.estimated_bw;
-                       notify->dpia_notification.payload.data.dpia_bw_alloc.allocated_bw =
-                                       cmd.dpia_notification.payload.data.dpia_bw_alloc.allocated_bw;
-
-                       if (cmd.dpia_notification.payload.data.dpia_bw_alloc.bits.bw_request_failed)
-                               notify->result = DPIA_BW_REQ_FAILED;
-                       else if (cmd.dpia_notification.payload.data.dpia_bw_alloc.bits.bw_request_succeeded)
-                               notify->result = DPIA_BW_REQ_SUCCESS;
-                       else if (cmd.dpia_notification.payload.data.dpia_bw_alloc.bits.est_bw_changed)
-                               notify->result = DPIA_EST_BW_CHANGED;
-                       else if (cmd.dpia_notification.payload.data.dpia_bw_alloc.bits.bw_alloc_cap_changed)
-                               notify->result = DPIA_BW_ALLOC_CAPS_CHANGED;
-               }
                break;
        case DMUB_OUT_CMD__HPD_SENSE_NOTIFY:
                notify->type = DMUB_NOTIFICATION_HPD_SENSE_NOTIFY;