spi: stm32: fix excluded_middle.cocci warnings
authorkernel test robot <lkp@intel.com>
Tue, 13 Jul 2021 19:10:04 +0000 (03:10 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 20 Aug 2021 12:07:27 +0000 (13:07 +0100)
drivers/spi/spi-stm32.c:915:23-25: WARNING !A || A && B is equivalent to !A || B

 Condition !A || A && B is equivalent to !A || B.

Generated by: scripts/coccinelle/misc/excluded_middle.cocci

Fixes: 7ceb0b8a3ced ("spi: stm32: finalize message either on dma callback or EOT")
CC: Alain Volmat <alain.volmat@foss.st.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Reviewed-by: Alain Volmat <alain.volmat@foss.st.com>
Link: https://lore.kernel.org/r/20210713191004.GA14729@5eb5c2cbef84
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-stm32.c

index 14ca7ea04e477abf9addf28b4d3b9934a47ed101..9bd3fd1652f744bc6132198414a2e790f3866a81 100644 (file)
@@ -912,8 +912,7 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id)
                if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0)))
                        stm32h7_spi_read_rxfifo(spi);
                if (!spi->cur_usedma ||
-                   (spi->cur_usedma && (spi->cur_comm == SPI_SIMPLEX_TX ||
-                    spi->cur_comm == SPI_3WIRE_TX)))
+                   (spi->cur_comm == SPI_SIMPLEX_TX || spi->cur_comm == SPI_3WIRE_TX))
                        end = true;
        }