ASoC: mediatek: mt8188: avoid uninitialized variable use
authorArnd Bergmann <arnd@arndb.de>
Thu, 27 Feb 2025 13:19:01 +0000 (14:19 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 27 Feb 2025 14:06:00 +0000 (14:06 +0000)
The 'msk' variable has no initialization:

sound/soc/mediatek/mt8188/mt8188-dai-dmic.c:311:4: error: variable 'msk' is uninitialized when used here [-Werror,-Wuninitialized]
  311 |                         msk |= PWR2_TOP_CON1_DMIC_FIFO_SOFT_RST_EN(i);
      |                         ^~~

Set it to zero before the loop.

Fixes: c1e42ec04197 ("ASoC: mediatek: mt8188: Add support for DMIC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: NĂ­colas F. R. A. Prado <nfraprado@collabora.com>
Link: https://patch.msgid.link/20250227131939.1040168-1-arnd@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mediatek/mt8188/mt8188-dai-dmic.c

index 4cfbcb71d2d9c73e9c6b355a655f78709a032af5..adcea7818be20a94242db0c9d50e845a1e842e8c 100644 (file)
@@ -307,6 +307,7 @@ static int mtk_dmic_event(struct snd_soc_dapm_widget *w,
        switch (event) {
        case SND_SOC_DAPM_PRE_PMU:
                /* request fifo soft rst */
+               msk = 0;
                for (i = dmic_num; i >= DMIC0; i--)
                        msk |= PWR2_TOP_CON1_DMIC_FIFO_SOFT_RST_EN(i);