projects
/
linux-2.6-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
ac55d16
)
usb: cdnsp: Fix segmentation fault in cdns_lost_power function
author
Pawel Laszczak
<pawell@cadence.com>
Tue, 11 Jan 2022 09:07:37 +0000
(10:07 +0100)
committer
Greg Kroah-Hartman
<gregkh@linuxfoundation.org>
Wed, 26 Jan 2022 13:11:16 +0000
(14:11 +0100)
CDNSP driver read not initialized cdns->otg_v0_regs
which lead to segmentation fault. Patch fixes this issue.
Fixes:
2cf2581cd229
("usb: cdns3: add power lost support for system resume")
cc: <stable@vger.kernel.org>
Signed-off-by: Pawel Laszczak <pawell@cadence.com>
Link:
https://lore.kernel.org/r/20220111090737.10345-1-pawell@gli-login.cadence.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/cdns3/drd.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/usb/cdns3/drd.c
b/drivers/usb/cdns3/drd.c
index 55c73b1d870471bff520b619fa27b6a94ee752d8..d00ff98dffabfa9cc1fdcde47212b9a0af843b7e 100644
(file)
--- a/
drivers/usb/cdns3/drd.c
+++ b/
drivers/usb/cdns3/drd.c
@@
-483,11
+483,11
@@
int cdns_drd_exit(struct cdns *cdns)
/* Indicate the cdns3 core was power lost before */
bool cdns_power_is_lost(struct cdns *cdns)
{
- if (cdns->version == CDNS3_CONTROLLER_V
1
) {
- if (!(readl(&cdns->otg_v
1
_regs->simulate) & BIT(0)))
+ if (cdns->version == CDNS3_CONTROLLER_V
0
) {
+ if (!(readl(&cdns->otg_v
0
_regs->simulate) & BIT(0)))
return true;
} else {
- if (!(readl(&cdns->otg_v
0
_regs->simulate) & BIT(0)))
+ if (!(readl(&cdns->otg_v
1
_regs->simulate) & BIT(0)))
return true;
}
return false;