clocksource/drivers/mips-gic-timer: Remove pointless irq_save,restore
authorMatt Redfearn <matt.redfearn@mips.com>
Thu, 19 Oct 2017 11:55:34 +0000 (12:55 +0100)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Thu, 19 Oct 2017 21:49:45 +0000 (23:49 +0200)
The function gic_next_event is always called with interrupts disabled, so
the local_irq_save / local_irq_restore are pointless - remove them.

[Daniel Lezcano: Fixed warning by removing unused variable 'flags']

Signed-off-by: Matt Redfearn <matt.redfearn@mips.com>
Suggested-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reported-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
drivers/clocksource/mips-gic-timer.c

index ae3167c28b129b6c3d3cc0fbc5c4a0da1a9abacd..775dea04460de8ccae8652e49c50019a4ee15f87 100644 (file)
@@ -39,16 +39,13 @@ static u64 notrace gic_read_count(void)
 
 static int gic_next_event(unsigned long delta, struct clock_event_device *evt)
 {
-       unsigned long flags;
        u64 cnt;
        int res;
 
        cnt = gic_read_count();
        cnt += (u64)delta;
-       local_irq_save(flags);
        write_gic_vl_other(mips_cm_vp_id(cpumask_first(evt->cpumask)));
        write_gic_vo_compare(cnt);
-       local_irq_restore(flags);
        res = ((int)(gic_read_count() - cnt) >= 0) ? -ETIME : 0;
        return res;
 }