wl1251: Fix regression in IRQ loop handling
authorJuuso Oikarinen <juuso.oikarinen@nokia.com>
Tue, 17 Nov 2009 16:49:46 +0000 (18:49 +0200)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 18 Nov 2009 22:09:23 +0000 (17:09 -0500)
In some cases, the IRQ loop handler could acknowledge an interrupt to
the chipset, but not service it.

Signed-off-by: Juuso Oikarinen <juuso.oikarinen@nokia.com>
Reviewed-by: Janne Ylalehto <janne.ylalehto@nokia.com>
Signed-off-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/wl12xx/wl1251_main.c

index dad010d114f8a7820bd5d139e7a3fe96af1bd721..2e1c10f9670ae06619573b13227248eb0a13e69a 100644 (file)
@@ -308,9 +308,11 @@ static void wl1251_irq_work(struct work_struct *work)
                        wl1251_debug(DEBUG_IRQ,
                                     "WL1251_ACX_INTR_INIT_COMPLETE");
 
-               intr = wl1251_reg_read32(wl, ACX_REG_INTERRUPT_CLEAR);
+               if (--ctr == 0)
+                       break;
 
-       } while (intr && --ctr);
+               intr = wl1251_reg_read32(wl, ACX_REG_INTERRUPT_CLEAR);
+       } while (intr);
 
 out_sleep:
        wl1251_reg_write32(wl, ACX_REG_INTERRUPT_MASK, ~(wl->intr_mask));