rtc: imx-sc: remove .read_alarm
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Sat, 17 Apr 2021 23:52:05 +0000 (01:52 +0200)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Thu, 29 Apr 2021 21:03:26 +0000 (23:03 +0200)
The RTC core properly handles RTC without .read_alarm and doesn't use it to
set alarms. .read_alarm can be safely dropped.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
Link: https://lore.kernel.org/r/20210417235205.994119-1-alexandre.belloni@bootlin.com
drivers/rtc/rtc-imx-sc.c

index cc9fbab499994e901aa341653656ed7db7057987..814d516645e28307f1121ab9987cc3e00a1ba716 100644 (file)
@@ -80,16 +80,6 @@ static int imx_sc_rtc_alarm_irq_enable(struct device *dev, unsigned int enable)
        return imx_scu_irq_group_enable(SC_IRQ_GROUP_RTC, SC_IRQ_RTC, enable);
 }
 
-static int imx_sc_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
-{
-       /*
-        * SCU firmware does NOT provide read alarm API, but .read_alarm
-        * callback is required by RTC framework to support alarm function,
-        * so just return here.
-        */
-       return 0;
-}
-
 static int imx_sc_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
 {
        struct imx_sc_msg_timer_rtc_set_alarm msg;
@@ -127,7 +117,6 @@ static int imx_sc_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
 static const struct rtc_class_ops imx_sc_rtc_ops = {
        .read_time = imx_sc_rtc_read_time,
        .set_time = imx_sc_rtc_set_time,
-       .read_alarm = imx_sc_rtc_read_alarm,
        .set_alarm = imx_sc_rtc_set_alarm,
        .alarm_irq_enable = imx_sc_rtc_alarm_irq_enable,
 };