drm: mxsfb: Use LCDC_CTRL register name explicitly
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Mon, 27 Jul 2020 02:06:39 +0000 (05:06 +0300)
committerStefan Agner <stefan@agner.ch>
Tue, 28 Jul 2020 15:20:47 +0000 (17:20 +0200)
The LCDC_CTRL register is located at address 0x0000. Some of the
accesses to the register simply use the mxsfb->base address. Reference
the LCDC_CTRL register explicitly instead to clarify the code.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Signed-off-by: Stefan Agner <stefan@agner.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200727020654.8231-8-laurent.pinchart@ideasonboard.com
drivers/gpu/drm/mxsfb/mxsfb_crtc.c

index be60c4021e2fbba73aac09a0eed7646f45311c1c..722bd9b4f5f9aea5dcfdaeaf36bb7db7a3d3a72f 100644 (file)
@@ -170,17 +170,17 @@ static int mxsfb_reset_block(struct mxsfb_drm_private *mxsfb)
 {
        int ret;
 
-       ret = clear_poll_bit(mxsfb->base, MODULE_SFTRST);
+       ret = clear_poll_bit(mxsfb->base + LCDC_CTRL, MODULE_SFTRST);
        if (ret)
                return ret;
 
-       writel(MODULE_CLKGATE, mxsfb->base + MXS_CLR_ADDR);
+       writel(MODULE_CLKGATE, mxsfb->base + LCDC_CTRL + MXS_CLR_ADDR);
 
-       ret = clear_poll_bit(mxsfb->base, MODULE_SFTRST);
+       ret = clear_poll_bit(mxsfb->base + LCDC_CTRL, MODULE_SFTRST);
        if (ret)
                return ret;
 
-       return clear_poll_bit(mxsfb->base, MODULE_CLKGATE);
+       return clear_poll_bit(mxsfb->base + LCDC_CTRL, MODULE_CLKGATE);
 }
 
 static dma_addr_t mxsfb_get_fb_paddr(struct mxsfb_drm_private *mxsfb)