drm/i915: Noop lrc_init_wa_ctx() on recent/future platforms
authorLucas De Marchi <lucas.demarchi@intel.com>
Wed, 7 Sep 2022 23:08:41 +0000 (16:08 -0700)
committerLucas De Marchi <lucas.demarchi@intel.com>
Thu, 22 Sep 2022 13:52:07 +0000 (06:52 -0700)
Except for graphics version 8 and 9, nothing is done in
lrc_init_wa_ctx(). Assume this won't be needed on future platforms as
well and remove the warning.

Note that this function is not called for anything below version 8 since
those don't use either guc or execlist, i.e. HAS_EXECLISTS() is false.

Reviewed-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220907230841.1703574-1-lucas.demarchi@intel.com
drivers/gpu/drm/i915/gt/intel_lrc.c

index 3955292483a6f13b2ce547807c4554208b72c8c1..82d899f170fb305f336d4a3335f4b2ddea3b135b 100644 (file)
@@ -1718,24 +1718,16 @@ void lrc_init_wa_ctx(struct intel_engine_cs *engine)
        unsigned int i;
        int err;
 
-       if (!(engine->flags & I915_ENGINE_HAS_RCS_REG_STATE))
+       if (GRAPHICS_VER(engine->i915) >= 11 ||
+           !(engine->flags & I915_ENGINE_HAS_RCS_REG_STATE))
                return;
 
-       switch (GRAPHICS_VER(engine->i915)) {
-       case 12:
-       case 11:
-               return;
-       case 9:
+       if (GRAPHICS_VER(engine->i915) == 9) {
                wa_bb_fn[0] = gen9_init_indirectctx_bb;
                wa_bb_fn[1] = NULL;
-               break;
-       case 8:
+       } else if (GRAPHICS_VER(engine->i915) == 8) {
                wa_bb_fn[0] = gen8_init_indirectctx_bb;
                wa_bb_fn[1] = NULL;
-               break;
-       default:
-               MISSING_CASE(GRAPHICS_VER(engine->i915));
-               return;
        }
 
        err = lrc_create_wa_ctx(engine);