net: dsa: vsc73xx: Add null pointer check to vsc73xx_gpio_probe
authorKunwu Chan <chentao@kylinos.cn>
Thu, 11 Jan 2024 07:20:18 +0000 (15:20 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 17 Jan 2024 01:48:27 +0000 (17:48 -0800)
devm_kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure.

Fixes: 05bd97fc559d ("net: dsa: Add Vitesse VSC73xx DSA router driver")
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240111072018.75971-1-chentao@kylinos.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/vitesse-vsc73xx-core.c

index dd50502e21229652fed0fcf73e2b73975bdf010c..ae70eac3be28f84ec3ad00910faf3b4dcbe6bddc 100644 (file)
@@ -1135,6 +1135,8 @@ static int vsc73xx_gpio_probe(struct vsc73xx *vsc)
 
        vsc->gc.label = devm_kasprintf(vsc->dev, GFP_KERNEL, "VSC%04x",
                                       vsc->chipid);
+       if (!vsc->gc.label)
+               return -ENOMEM;
        vsc->gc.ngpio = 4;
        vsc->gc.owner = THIS_MODULE;
        vsc->gc.parent = vsc->dev;