projects
/
linux-block.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
68fffc1
)
spi: tegra20: Simplify with dev_err_probe()
author
Krzysztof Kozlowski
<krzk@kernel.org>
Tue, 1 Sep 2020 15:27:13 +0000
(17:27 +0200)
committer
Mark Brown
<broonie@kernel.org>
Tue, 8 Sep 2020 17:19:31 +0000
(18:19 +0100)
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link:
https://lore.kernel.org/r/20200901152713.18629-11-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-tegra20-slink.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/spi/spi-tegra20-slink.c
b/drivers/spi/spi-tegra20-slink.c
index a07b72e9c344847e38099eff64565f51c6887b86..a0810765d4e525e2150d888c182cc579526c9a36 100644
(file)
--- a/
drivers/spi/spi-tegra20-slink.c
+++ b/
drivers/spi/spi-tegra20-slink.c
@@
-600,13
+600,9
@@
static int tegra_slink_init_dma_param(struct tegra_slink_data *tspi,
struct dma_slave_config dma_sconfig;
dma_chan = dma_request_chan(tspi->dev, dma_to_memory ? "rx" : "tx");
- if (IS_ERR(dma_chan)) {
- ret = PTR_ERR(dma_chan);
- if (ret != -EPROBE_DEFER)
- dev_err(tspi->dev,
- "Dma channel is not available: %d\n", ret);
- return ret;
- }
+ if (IS_ERR(dma_chan))
+ return dev_err_probe(tspi->dev, PTR_ERR(dma_chan),
+ "Dma channel is not available\n");
dma_buf = dma_alloc_coherent(tspi->dev, tspi->dma_buf_size,
&dma_phys, GFP_KERNEL);