ASoC: soc-ac97: Return correct error codes
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 15 Feb 2023 13:23:43 +0000 (15:23 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 15 Feb 2023 16:09:07 +0000 (16:09 +0000)
With the switching to dev_err_probe(), during the conversion
of GPIO calls, the return code is passed is a paratemer to it.
At the same time a copy'n'paste mistake was made, so the wrong
variable has been taken for the error reporting. Fix this.

Fixes: 3ee0d39c50dc ("ASoC: soc-ac97: Convert to agnostic GPIO API")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230215132343.35547-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-ac97.c

index 40051f513c6afcd7812c25048e53dcd11eda95fd..4e4fe29ade502f7a6e16ea068f3866185d703ff4 100644 (file)
@@ -336,12 +336,12 @@ static int snd_soc_ac97_parse_pinctl(struct device *dev,
 
        cfg->sdata_gpio = devm_gpiod_get_index(dev, "ac97", 1, GPIOD_ASIS);
        if (IS_ERR(cfg->sdata_gpio))
-               return dev_err_probe(dev, PTR_ERR(cfg->sync_gpio), "Can't find ac97-sdata gpio\n");
+               return dev_err_probe(dev, PTR_ERR(cfg->sdata_gpio), "Can't find ac97-sdata gpio\n");
        gpiod_set_consumer_name(cfg->sdata_gpio, "AC97 link sdata");
 
        cfg->reset_gpio = devm_gpiod_get_index(dev, "ac97", 2, GPIOD_ASIS);
        if (IS_ERR(cfg->reset_gpio))
-               return dev_err_probe(dev, PTR_ERR(cfg->sync_gpio), "Can't find ac97-reset gpio\n");
+               return dev_err_probe(dev, PTR_ERR(cfg->reset_gpio), "Can't find ac97-reset gpio\n");
        gpiod_set_consumer_name(cfg->reset_gpio, "AC97 link reset");
 
        return 0;