net: dsa: rzn1_a5psw: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/dsa/rzn1_a5psw.c b/drivers/net/dsa/rzn1_a5psw.c
index 2eda10b33f2e5d602167b8b684a2c3bab34a5e87..10092ea85e46d55565895387cb409362fcfe2090 100644 (file)
--- a/drivers/net/dsa/rzn1_a5psw.c
+++ b/drivers/net/dsa/rzn1_a5psw.c
@@ -1272,19 +1272,17 @@ free_pcs:
        return ret;
 }
 
-static int a5psw_remove(struct platform_device *pdev)
+static void a5psw_remove(struct platform_device *pdev)
 {
        struct a5psw *a5psw = platform_get_drvdata(pdev);
 
        if (!a5psw)
-               return 0;
+               return;
 
        dsa_unregister_switch(&a5psw->ds);
        a5psw_pcs_free(a5psw);
        clk_disable_unprepare(a5psw->hclk);
        clk_disable_unprepare(a5psw->clk);
-
-       return 0;
 }
 
 static void a5psw_shutdown(struct platform_device *pdev)
@@ -1311,7 +1309,7 @@ static struct platform_driver a5psw_driver = {
                .of_match_table = a5psw_of_mtable,
        },
        .probe = a5psw_probe,
-       .remove = a5psw_remove,
+       .remove_new = a5psw_remove,
        .shutdown = a5psw_shutdown,
 };
 module_platform_driver(a5psw_driver);