drm/panel: visionox-rm69299: Remove redundant assignments of panel fields
authorChen-Yu Tsai <wenst@chromium.org>
Wed, 4 Dec 2024 09:39:41 +0000 (17:39 +0800)
committerChen-Yu Tsai <wenst@chromium.org>
Fri, 6 Dec 2024 07:18:40 +0000 (15:18 +0800)
drm_panel_init() was made to initialize the fields in |struct drm_panel|.
There is no need to separately initialize them again.

Drop the separate assignments that are redundant. Also fix up any uses
of `ctx->panel.dev` to use `dev` directly.

Reviewed-by: Jessica Zhang <quic_jesszhan@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241204093942.1374693-1-wenst@chromium.org
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
drivers/gpu/drm/panel/panel-visionox-rm69299.c

index 272490b9565bbb7361d315a6a3ad84df2bc333ac..be3a9797fbced5222b313cf83f8078b919e2c219 100644 (file)
@@ -193,7 +193,6 @@ static int visionox_rm69299_probe(struct mipi_dsi_device *dsi)
 
        mipi_dsi_set_drvdata(dsi, ctx);
 
-       ctx->panel.dev = dev;
        ctx->dsi = dsi;
 
        ctx->supplies[0].supply = "vdda";
@@ -201,13 +200,11 @@ static int visionox_rm69299_probe(struct mipi_dsi_device *dsi)
        ctx->supplies[1].supply = "vdd3p3";
        ctx->supplies[1].init_load_uA = 13200;
 
-       ret = devm_regulator_bulk_get(ctx->panel.dev, ARRAY_SIZE(ctx->supplies),
-                                     ctx->supplies);
+       ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), ctx->supplies);
        if (ret < 0)
                return ret;
 
-       ctx->reset_gpio = devm_gpiod_get(ctx->panel.dev,
-                                        "reset", GPIOD_OUT_LOW);
+       ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
        if (IS_ERR(ctx->reset_gpio)) {
                dev_err(dev, "cannot get reset gpio %ld\n", PTR_ERR(ctx->reset_gpio));
                return PTR_ERR(ctx->reset_gpio);
@@ -215,8 +212,6 @@ static int visionox_rm69299_probe(struct mipi_dsi_device *dsi)
 
        drm_panel_init(&ctx->panel, dev, &visionox_rm69299_drm_funcs,
                       DRM_MODE_CONNECTOR_DSI);
-       ctx->panel.dev = dev;
-       ctx->panel.funcs = &visionox_rm69299_drm_funcs;
        drm_panel_add(&ctx->panel);
 
        dsi->lanes = 4;