vfio/platform: Use GFP_KERNEL_ACCOUNT for userspace persistent allocations
authorYishai Hadas <yishaih@nvidia.com>
Sun, 8 Jan 2023 15:44:27 +0000 (17:44 +0200)
committerAlex Williamson <alex.williamson@redhat.com>
Mon, 23 Jan 2023 18:26:30 +0000 (11:26 -0700)
Use GFP_KERNEL_ACCOUNT for userspace persistent allocations.

The GFP_KERNEL_ACCOUNT option lets the memory allocator know that this
is untrusted allocation triggered from userspace and should be a subject
of kmem accounting, and as such it is controlled by the cgroup
mechanism.

Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20230108154427.32609-7-yishaih@nvidia.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
drivers/vfio/platform/vfio_platform_common.c
drivers/vfio/platform/vfio_platform_irq.c

index a9ad3f4d2613722c791106da9078264e5458b8fe..9f27e8c30c9283e667ce9c8b55cfb43b4ae6a6ca 100644 (file)
@@ -142,7 +142,7 @@ static int vfio_platform_regions_init(struct vfio_platform_device *vdev)
                cnt++;
 
        vdev->regions = kcalloc(cnt, sizeof(struct vfio_platform_region),
-                               GFP_KERNEL);
+                               GFP_KERNEL_ACCOUNT);
        if (!vdev->regions)
                return -ENOMEM;
 
index c5b09ec0a3c981499c81befff6a18871c8f18e05..665197caed89e41ad042c87a897c411047561602 100644 (file)
@@ -186,9 +186,8 @@ static int vfio_set_trigger(struct vfio_platform_device *vdev, int index,
 
        if (fd < 0) /* Disable only */
                return 0;
-
-       irq->name = kasprintf(GFP_KERNEL, "vfio-irq[%d](%s)",
-                                               irq->hwirq, vdev->name);
+       irq->name = kasprintf(GFP_KERNEL_ACCOUNT, "vfio-irq[%d](%s)",
+                             irq->hwirq, vdev->name);
        if (!irq->name)
                return -ENOMEM;
 
@@ -286,7 +285,8 @@ int vfio_platform_irq_init(struct vfio_platform_device *vdev)
        while (vdev->get_irq(vdev, cnt) >= 0)
                cnt++;
 
-       vdev->irqs = kcalloc(cnt, sizeof(struct vfio_platform_irq), GFP_KERNEL);
+       vdev->irqs = kcalloc(cnt, sizeof(struct vfio_platform_irq),
+                            GFP_KERNEL_ACCOUNT);
        if (!vdev->irqs)
                return -ENOMEM;