irqchip/gic-v3-its: Make its_send_vmapp operate on a single ITS
authorMarc Zyngier <marc.zyngier@arm.com>
Sun, 8 Oct 2017 17:46:39 +0000 (18:46 +0100)
committerMarc Zyngier <marc.zyngier@arm.com>
Thu, 19 Oct 2017 10:22:41 +0000 (11:22 +0100)
Currently, its_send_vmapp operates on all ITSs. As we're about
to try and limit the amount of commands we send to ITSs that are
not involved in dealing with a given VM, let's redefine that
primitive so that it takes a target ITS as a parameter.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
drivers/irqchip/irq-gic-v3-its.c

index 22ee830437854cd89feb44f06587be3d9bb46453..b14585d6397be4411978c6b1bf35e894556c7833 100644 (file)
@@ -924,21 +924,16 @@ static void its_send_vmovi(struct its_device *dev, u32 id)
        its_send_single_vcommand(dev->its, its_build_vmovi_cmd, &desc);
 }
 
-static void its_send_vmapp(struct its_vpe *vpe, bool valid)
+static void its_send_vmapp(struct its_node *its,
+                          struct its_vpe *vpe, bool valid)
 {
        struct its_cmd_desc desc;
-       struct its_node *its;
 
        desc.its_vmapp_cmd.vpe = vpe;
        desc.its_vmapp_cmd.valid = valid;
+       desc.its_vmapp_cmd.col = &its->collections[vpe->col_idx];
 
-       list_for_each_entry(its, &its_nodes, entry) {
-               if (!its->is_v4)
-                       continue;
-
-               desc.its_vmapp_cmd.col = &its->collections[vpe->col_idx];
-               its_send_single_vcommand(its, its_build_vmapp_cmd, &desc);
-       }
+       its_send_single_vcommand(its, its_build_vmapp_cmd, &desc);
 }
 
 static void its_send_vmovp(struct its_vpe *vpe)
@@ -2720,12 +2715,12 @@ static int its_vpe_irq_domain_activate(struct irq_domain *domain,
 
        /* Map the VPE to the first possible CPU */
        vpe->col_idx = cpumask_first(cpu_online_mask);
-       its_send_vmapp(vpe, true);
 
        list_for_each_entry(its, &its_nodes, entry) {
                if (!its->is_v4)
                        continue;
 
+               its_send_vmapp(its, vpe, true);
                its_send_vinvall(its, vpe);
        }
 
@@ -2736,8 +2731,14 @@ static void its_vpe_irq_domain_deactivate(struct irq_domain *domain,
                                          struct irq_data *d)
 {
        struct its_vpe *vpe = irq_data_get_irq_chip_data(d);
+       struct its_node *its;
+
+       list_for_each_entry(its, &its_nodes, entry) {
+               if (!its->is_v4)
+                       continue;
 
-       its_send_vmapp(vpe, false);
+               its_send_vmapp(its, vpe, false);
+       }
 }
 
 static const struct irq_domain_ops its_vpe_domain_ops = {