s390/qeth: remove QETH_QDIO_BUF_HANDLED_DELAYED state
authorJulian Wiedmann <jwi@linux.ibm.com>
Mon, 7 Dec 2020 13:12:32 +0000 (14:12 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Dec 2020 14:55:21 +0000 (06:55 -0800)
Reuse the QETH_QDIO_BUF_EMPTY state to indicate that a TX buffer has
been completed with a QAOB notification, and may be cleaned up by
qeth_cleanup_handled_pending().

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core.h
drivers/s390/net/qeth_core_main.c

index d150da95d073d026fc4ed76f41fd20632ce0fbe9..6f5ddc3eab8c5243f32f7c75e2edeee8dd416cc1 100644 (file)
@@ -424,8 +424,6 @@ enum qeth_qdio_out_buffer_state {
        /* Received QAOB notification on CQ: */
        QETH_QDIO_BUF_QAOB_OK,
        QETH_QDIO_BUF_QAOB_ERROR,
-       /* Handled via transfer pending / completion queue. */
-       QETH_QDIO_BUF_HANDLED_DELAYED,
 };
 
 struct qeth_qdio_out_buffer {
index 869694217450f21456aa7c2811c5b3c10b3d6028..da27ef451d05ad731406af5ddf523b2081b8be23 100644 (file)
@@ -477,8 +477,7 @@ static void qeth_cleanup_handled_pending(struct qeth_qdio_out_q *q, int bidx,
 
                while (c) {
                        if (forced_cleanup ||
-                           atomic_read(&c->state) ==
-                             QETH_QDIO_BUF_HANDLED_DELAYED) {
+                           atomic_read(&c->state) == QETH_QDIO_BUF_EMPTY) {
                                struct qeth_qdio_out_buffer *f = c;
 
                                QETH_CARD_TEXT(f->q->card, 5, "fp");
@@ -549,7 +548,7 @@ static void qeth_qdio_handle_aob(struct qeth_card *card,
                                kmem_cache_free(qeth_core_header_cache, data);
                }
 
-               atomic_set(&buffer->state, QETH_QDIO_BUF_HANDLED_DELAYED);
+               atomic_set(&buffer->state, QETH_QDIO_BUF_EMPTY);
                break;
        default:
                WARN_ON_ONCE(1);