PCI/pwrctrl: Add pwrctrl driver for PCI slots
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thu, 16 Jan 2025 14:09:15 +0000 (19:39 +0530)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Fri, 21 Feb 2025 01:03:39 +0000 (01:03 +0000)
This driver is used to control the power state of the devices attached to
the PCI slots. Currently, it controls the voltage rails of the PCI slots
defined in the devicetree node of the root port.

The voltage rails for PCI slots are documented in the DT-schema:

  https://github.com/devicetree-org/dt-schema/blob/v2024.11/dtschema/schemas/pci/pci-bus-common.yaml#L153

Since this driver has to work with different kind of slots (PCIe
x1/x4/x8/x16, Mini PCIe, PCI, etc.), the driver is thus using the
of_regulator_bulk_get_all() API to obtain the voltage regulators defined
in the DT node, instead of hardcoding them.

As such, the DT node of the root port should define the relevant supply
properties corresponding to the voltage rails of the PCI slot.

Tested-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20250116-pci-pwrctrl-slot-v3-5-827473c8fbf4@linaro.org
[kwilczynski: commit log]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
drivers/pci/pwrctrl/Kconfig
drivers/pci/pwrctrl/Makefile
drivers/pci/pwrctrl/slot.c [new file with mode: 0644]

index 54589bb2403b9d67731b7a1c1b733ed50cfeca85..990cab67d41332a8508d4150825c621eb86322c5 100644 (file)
@@ -10,3 +10,14 @@ config PCI_PWRCTL_PWRSEQ
        tristate
        select POWER_SEQUENCING
        select PCI_PWRCTL
+
+config PCI_PWRCTL_SLOT
+       tristate "PCI Power Control driver for PCI slots"
+       select PCI_PWRCTL
+       help
+         Say Y here to enable the PCI Power Control driver to control the power
+         state of PCI slots.
+
+         This is a generic driver that controls the power state of different
+         PCI slots. The voltage regulators powering the rails of the PCI slots
+         are expected to be defined in the devicetree node of the PCI bridge.
index 75c7ce531c7e27ab85762e25bb4a2fafc8218dd2..ddfb12c5aadf684cf675585b1078ecb7c24649cc 100644 (file)
@@ -4,3 +4,6 @@ obj-$(CONFIG_PCI_PWRCTL)                += pci-pwrctrl-core.o
 pci-pwrctrl-core-y                     := core.o
 
 obj-$(CONFIG_PCI_PWRCTL_PWRSEQ)                += pci-pwrctrl-pwrseq.o
+
+obj-$(CONFIG_PCI_PWRCTL_SLOT)          += pci-pwrctl-slot.o
+pci-pwrctl-slot-y                      := slot.o
diff --git a/drivers/pci/pwrctrl/slot.c b/drivers/pci/pwrctrl/slot.c
new file mode 100644 (file)
index 0000000..18becc1
--- /dev/null
@@ -0,0 +1,93 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2024 Linaro Ltd.
+ * Author: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
+ */
+
+#include <linux/device.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+#include <linux/pci-pwrctrl.h>
+#include <linux/platform_device.h>
+#include <linux/regulator/consumer.h>
+#include <linux/slab.h>
+
+struct pci_pwrctrl_slot_data {
+       struct pci_pwrctrl ctx;
+       struct regulator_bulk_data *supplies;
+       int num_supplies;
+};
+
+static void devm_pci_pwrctrl_slot_power_off(void *data)
+{
+       struct pci_pwrctrl_slot_data *slot = data;
+
+       regulator_bulk_disable(slot->num_supplies, slot->supplies);
+       regulator_bulk_free(slot->num_supplies, slot->supplies);
+}
+
+static int pci_pwrctrl_slot_probe(struct platform_device *pdev)
+{
+       struct pci_pwrctrl_slot_data *slot;
+       struct device *dev = &pdev->dev;
+       int ret;
+
+       slot = devm_kzalloc(dev, sizeof(*slot), GFP_KERNEL);
+       if (!slot)
+               return -ENOMEM;
+
+       ret = of_regulator_bulk_get_all(dev, dev_of_node(dev),
+                                       &slot->supplies);
+       if (ret < 0) {
+               dev_err_probe(dev, ret, "Failed to get slot regulators\n");
+               return ret;
+       }
+
+       slot->num_supplies = ret;
+       ret = regulator_bulk_enable(slot->num_supplies, slot->supplies);
+       if (ret < 0) {
+               dev_err_probe(dev, ret, "Failed to enable slot regulators\n");
+               goto err_regulator_free;
+       }
+
+       ret = devm_add_action_or_reset(dev, devm_pci_pwrctrl_slot_power_off,
+                                      slot);
+       if (ret)
+               goto err_regulator_disable;
+
+       pci_pwrctrl_init(&slot->ctx, dev);
+
+       ret = devm_pci_pwrctrl_device_set_ready(dev, &slot->ctx);
+       if (ret)
+               return dev_err_probe(dev, ret, "Failed to register pwrctrl driver\n");
+
+       return 0;
+
+err_regulator_disable:
+       regulator_bulk_disable(slot->num_supplies, slot->supplies);
+err_regulator_free:
+       regulator_bulk_free(slot->num_supplies, slot->supplies);
+
+       return ret;
+}
+
+static const struct of_device_id pci_pwrctrl_slot_of_match[] = {
+       {
+               .compatible = "pciclass,0604",
+       },
+       { }
+};
+MODULE_DEVICE_TABLE(of, pci_pwrctrl_slot_of_match);
+
+static struct platform_driver pci_pwrctrl_slot_driver = {
+       .driver = {
+               .name = "pci-pwrctrl-slot",
+               .of_match_table = pci_pwrctrl_slot_of_match,
+       },
+       .probe = pci_pwrctrl_slot_probe,
+};
+module_platform_driver(pci_pwrctrl_slot_driver);
+
+MODULE_AUTHOR("Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>");
+MODULE_DESCRIPTION("Generic PCI Power Control driver for PCI Slots");
+MODULE_LICENSE("GPL");