powerpc: DebugException remove args
authorNicholas Piggin <npiggin@gmail.com>
Sat, 30 Jan 2021 13:08:19 +0000 (23:08 +1000)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 8 Feb 2021 13:02:09 +0000 (00:02 +1100)
Like other interrupt handler conversions, switch to getting registers
from the pt_regs argument.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20210130130852.2952424-10-npiggin@gmail.com
arch/powerpc/kernel/exceptions-64e.S
arch/powerpc/kernel/head_40x.S
arch/powerpc/kernel/head_booke.h
arch/powerpc/kernel/traps.c

index 43e71d86dcbf6f08bb28e026770d04ebe0d84d26..1a7291daadfd92f2e737b06c1a6bcfd3d6d074a3 100644 (file)
@@ -791,7 +791,6 @@ END_FTR_SECTION_IFSET(CPU_FTR_ALTIVEC)
        EXCEPTION_COMMON_CRIT(0xd00)
        std     r14,_DSISR(r1)
        addi    r3,r1,STACK_FRAME_OVERHEAD
-       mr      r4,r14
        ld      r14,PACA_EXCRIT+EX_R14(r13)
        ld      r15,PACA_EXCRIT+EX_R15(r13)
        bl      save_nvgprs
@@ -864,7 +863,6 @@ kernel_dbg_exc:
        INTS_DISABLE
        std     r14,_DSISR(r1)
        addi    r3,r1,STACK_FRAME_OVERHEAD
-       mr      r4,r14
        ld      r14,PACA_EXDBG+EX_R14(r13)
        ld      r15,PACA_EXDBG+EX_R15(r13)
        bl      save_nvgprs
index 3c5577ac4dc8ab93b42f2f94be1a36ed3e285b4b..24724a7dad49a678e689aa043b99193f89fa37ef 100644 (file)
@@ -476,6 +476,7 @@ _ENTRY(saved_ksp_limit)
 
        /* continue normal handling for a critical exception... */
 2:     mfspr   r4,SPRN_DBSR
+       stw     r4,_ESR(r11)            /* DebugException takes DBSR in _ESR */
        addi    r3,r1,STACK_FRAME_OVERHEAD
        EXC_XFER_TEMPLATE(DebugException, 0x2002, \
                (MSR_KERNEL & ~(MSR_ME|MSR_DE|MSR_CE)), \
index 0fbdacc7fab7827242a18477e4eca9f565a1d60a..bf33af714d1149d5ca507ab834e7afdbf931eb0c 100644 (file)
@@ -406,6 +406,7 @@ label:
                                                                              \
        /* continue normal handling for a debug exception... */               \
 2:     mfspr   r4,SPRN_DBSR;                                                 \
+       stw     r4,_ESR(r11);           /* DebugException takes DBSR in _ESR */\
        addi    r3,r1,STACK_FRAME_OVERHEAD;                                   \
        EXC_XFER_TEMPLATE(DebugException, 0x2008, (MSR_KERNEL & ~(MSR_ME|MSR_DE|MSR_CE)), debug_transfer_to_handler, ret_from_debug_exc)
 
@@ -459,6 +460,7 @@ label:
                                                                              \
        /* continue normal handling for a critical exception... */            \
 2:     mfspr   r4,SPRN_DBSR;                                                 \
+       stw     r4,_ESR(r11);           /* DebugException takes DBSR in _ESR */\
        addi    r3,r1,STACK_FRAME_OVERHEAD;                                   \
        EXC_XFER_TEMPLATE(DebugException, 0x2002, (MSR_KERNEL & ~(MSR_ME|MSR_DE|MSR_CE)), crit_transfer_to_handler, ret_from_crit_exc)
 
index 1c77b1a8f7c92c0d8de7788a495e353f2bbc1cf1..dfb0d3325f4b73ae62154178392bf4854516f283 100644 (file)
@@ -1957,8 +1957,10 @@ static void handle_debug(struct pt_regs *regs, unsigned long debug_status)
                mtspr(SPRN_DBCR0, current->thread.debug.dbcr0);
 }
 
-void DebugException(struct pt_regs *regs, unsigned long debug_status)
+void DebugException(struct pt_regs *regs)
 {
+       unsigned long debug_status = regs->dsisr;
+
        current->thread.debug.dbsr = debug_status;
 
        /* Hack alert: On BookE, Branch Taken stops on the branch itself, while