staging: HalBtc8723b1Ant: remove useless typedef's
authorMarco Cesati <marcocesati@gmail.com>
Fri, 5 Mar 2021 10:01:46 +0000 (11:01 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Mar 2021 08:25:33 +0000 (09:25 +0100)
This commit fixes the following checkpatch.pl warnings:

    WARNING: do not add new typedefs
    #24: FILE: hal/HalBtc8723b1Ant.h:24:
    +typedef enum _BT_INFO_SRC_8723B_1ANT {

    WARNING: do not add new typedefs
    #31: FILE: hal/HalBtc8723b1Ant.h:31:
    +typedef enum _BT_8723B_1ANT_BT_STATUS {

    WARNING: do not add new typedefs
    #41: FILE: hal/HalBtc8723b1Ant.h:41:
    +typedef enum _BT_8723B_1ANT_WIFI_STATUS {

    WARNING: do not add new typedefs
    #51: FILE: hal/HalBtc8723b1Ant.h:51:
    +typedef enum _BT_8723B_1ANT_COEX_ALGO {

    WARNING: do not add new typedefs
    #66: FILE: hal/HalBtc8723b1Ant.h:66:
    +typedef struct _COEX_DM_8723B_1ANT {

    WARNING: do not add new typedefs
    #121: FILE: hal/HalBtc8723b1Ant.h:121:
    +typedef struct _COEX_STA_8723B_1ANT {

Signed-off-by: Marco Cesati <marco.cesati@gmail.com>
Link: https://lore.kernel.org/r/20210305100146.30687-1-marco.cesati@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c
drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h

index c60e8c58d9cc5731bd47ace9607ca3e9f0e327dc..ef8c6a0f31ae2f34358b7b8ca650dea09d86b5a9 100644 (file)
@@ -8,10 +8,10 @@
 #include "Mp_Precomp.h"
 
 /*  Global variables, these are static variables */
-static COEX_DM_8723B_1ANT GLCoexDm8723b1Ant;
-static PCOEX_DM_8723B_1ANT pCoexDm = &GLCoexDm8723b1Ant;
-static COEX_STA_8723B_1ANT GLCoexSta8723b1Ant;
-static PCOEX_STA_8723B_1ANT    pCoexSta = &GLCoexSta8723b1Ant;
+static struct COEX_DM_8723B_1ANT GLCoexDm8723b1Ant;
+static struct COEX_DM_8723B_1ANT * pCoexDm = &GLCoexDm8723b1Ant;
+static struct COEX_STA_8723B_1ANT GLCoexSta8723b1Ant;
+static struct COEX_STA_8723B_1ANT * pCoexSta = &GLCoexSta8723b1Ant;
 
 static const char *const GLBtInfoSrc8723b1Ant[] = {
        "BT Info[wifi fw]",
index cdffa391bd9d99f181b0bde224908736c8b9c69e..661f0cd6aa069ce77fc417191fc23b6ff131a96c 100644 (file)
 
 #define  BT_8723B_1ANT_WIFI_NOISY_THRESH 30   /* max: 255 */
 
-typedef enum _BT_INFO_SRC_8723B_1ANT {
+enum BT_INFO_SRC_8723B_1ANT {
        BT_INFO_SRC_8723B_1ANT_WIFI_FW                  = 0x0,
        BT_INFO_SRC_8723B_1ANT_BT_RSP                           = 0x1,
        BT_INFO_SRC_8723B_1ANT_BT_ACTIVE_SEND           = 0x2,
        BT_INFO_SRC_8723B_1ANT_MAX
-} BT_INFO_SRC_8723B_1ANT, *PBT_INFO_SRC_8723B_1ANT;
+};
 
-typedef enum _BT_8723B_1ANT_BT_STATUS {
+enum BT_8723B_1ANT_BT_STATUS {
        BT_8723B_1ANT_BT_STATUS_NON_CONNECTED_IDLE      = 0x0,
        BT_8723B_1ANT_BT_STATUS_CONNECTED_IDLE          = 0x1,
        BT_8723B_1ANT_BT_STATUS_INQ_PAGE                                = 0x2,
@@ -36,9 +36,9 @@ typedef enum _BT_8723B_1ANT_BT_STATUS {
        BT_8723B_1ANT_BT_STATUS_SCO_BUSY                                = 0x4,
        BT_8723B_1ANT_BT_STATUS_ACL_SCO_BUSY                    = 0x5,
        BT_8723B_1ANT_BT_STATUS_MAX
-} BT_8723B_1ANT_BT_STATUS, *PBT_8723B_1ANT_BT_STATUS;
+};
 
-typedef enum _BT_8723B_1ANT_WIFI_STATUS {
+enum BT_8723B_1ANT_WIFI_STATUS {
        BT_8723B_1ANT_WIFI_STATUS_NON_CONNECTED_IDLE           = 0x0,
        BT_8723B_1ANT_WIFI_STATUS_NON_CONNECTED_ASSO_AUTH_SCAN = 0x1,
        BT_8723B_1ANT_WIFI_STATUS_CONNECTED_SCAN               = 0x2,
@@ -46,9 +46,9 @@ typedef enum _BT_8723B_1ANT_WIFI_STATUS {
        BT_8723B_1ANT_WIFI_STATUS_CONNECTED_IDLE               = 0x4,
        BT_8723B_1ANT_WIFI_STATUS_CONNECTED_BUSY               = 0x5,
        BT_8723B_1ANT_WIFI_STATUS_MAX
-} BT_8723B_1ANT_WIFI_STATUS, *PBT_8723B_1ANT_WIFI_STATUS;
+};
 
-typedef enum _BT_8723B_1ANT_COEX_ALGO {
+enum BT_8723B_1ANT_COEX_ALGO {
        BT_8723B_1ANT_COEX_ALGO_UNDEFINED               = 0x0,
        BT_8723B_1ANT_COEX_ALGO_SCO                             = 0x1,
        BT_8723B_1ANT_COEX_ALGO_HID                             = 0x2,
@@ -61,9 +61,9 @@ typedef enum _BT_8723B_1ANT_COEX_ALGO {
        BT_8723B_1ANT_COEX_ALGO_HID_A2DP_PANEDR = 0x9,
        BT_8723B_1ANT_COEX_ALGO_HID_A2DP                = 0xa,
        BT_8723B_1ANT_COEX_ALGO_MAX                             = 0xb,
-} BT_8723B_1ANT_COEX_ALGO, *PBT_8723B_1ANT_COEX_ALGO;
+};
 
-typedef struct _COEX_DM_8723B_1ANT {
+struct COEX_DM_8723B_1ANT {
        /*  fw mechanism */
        bool bCurIgnoreWlanAct;
        bool bPreIgnoreWlanAct;
@@ -116,9 +116,9 @@ typedef struct _COEX_DM_8723B_1ANT {
        u32 nArpCnt;
 
        u8 errorCondition;
-} COEX_DM_8723B_1ANT, *PCOEX_DM_8723B_1ANT;
+};
 
-typedef struct _COEX_STA_8723B_1ANT {
+struct COEX_STA_8723B_1ANT {
        bool bBtLinkExist;
        bool bScoExist;
        bool bA2dpExist;
@@ -162,7 +162,7 @@ typedef struct _COEX_STA_8723B_1ANT {
        u8 nCoexTableType;
 
        bool bForceLpsOn;
-} COEX_STA_8723B_1ANT, *PCOEX_STA_8723B_1ANT;
+};
 
 /*  */
 /*  The following is interface which will notify coex module. */