drm/amd/display: checking for NULL instead of IS_ERR()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 6 Nov 2017 11:43:41 +0000 (14:43 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 7 Nov 2017 21:21:44 +0000 (16:21 -0500)
backlight_device_register() never returns NULL, it returns error
pointers on error so the check here is wrong.

Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

index 33a15a1d818ca2c52c3fcdcfb49b5f1b58cbe715..75f9383f5b9be6f93fa711ea4f5f41754528ee51 100644 (file)
@@ -1296,7 +1296,7 @@ amdgpu_dm_register_backlight_device(struct amdgpu_display_manager *dm)
                        &amdgpu_dm_backlight_ops,
                        &props);
 
-       if (NULL == dm->backlight_dev)
+       if (IS_ERR(dm->backlight_dev))
                DRM_ERROR("DM: Backlight registration failed!\n");
        else
                DRM_DEBUG_DRIVER("DM: Registered Backlight device: %s\n", bl_name);