Blackfin: H8606: fixup bogus ioresource init
authorThomas Gleixner <tglx@linutronix.de>
Sat, 23 Jul 2011 15:51:38 +0000 (15:51 +0000)
committerMike Frysinger <vapier@gentoo.org>
Tue, 25 Oct 2011 23:51:26 +0000 (19:51 -0400)
IRQF_SHARED is not part of the IORESOURCE_IRQ bits. It's expressed by
IORESOURCE_IRQ_SHAREABLE.

IORESOURCE_IRQ_HIGHEDGE and IRQF_TRIGGER_HIGH are contradicting
values, an interrupt can hardly be configured for both level and edge
at the same time. This was introduced in commit 45138439(Blackfin
arch: flash memory map and dm9000 resources updating) of course
without any hint in the changelog what the heck this is supposed to
do.

Acked-by: Javier Herrero <jherrero@hvsistemas.es>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
arch/blackfin/mach-bf533/boards/H8606.c

index eb325ed6607eb2019ba5dde3e9d620cc368e7c55..5da5787fc4efa8a091b3b67663d91ccbeffd9251 100644 (file)
@@ -54,7 +54,8 @@ static struct resource dm9000_resources[] = {
        [2] = {
                .start  = IRQ_PF10,
                .end    = IRQ_PF10,
-               .flags  = (IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHEDGE | IRQF_SHARED | IRQF_TRIGGER_HIGH),
+               .flags  = (IORESOURCE_IRQ | IORESOURCE_IRQ_HIGHEDGE |
+                          IORESOURCE_IRQ_SHAREABLE),
        },
 };