media: i2c: ov2685: Add print for power on write failed
authorLuca Weiss <luca@z3ntu.xyz>
Wed, 1 Feb 2023 17:06:59 +0000 (18:06 +0100)
committerMauro Carvalho Chehab <mchehab@kernel.org>
Mon, 20 Mar 2023 14:57:07 +0000 (15:57 +0100)
If the sensor doens't power up correctly, for example due to incorrect
devicetree description, the power up i2c writes will fail.

Add an error print for this situation.

Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
drivers/media/i2c/ov2685.c

index 1c80b121e7d6d0d67ae372eb8229ad35a31e3b2b..0eb41a63787e7b27669e1c37de3d2f542ac18286 100644 (file)
@@ -419,8 +419,10 @@ static int __ov2685_power_on(struct ov2685 *ov2685)
         * writing register before .s_stream() as a workaround
         */
        ret = ov2685_write_array(ov2685->client, ov2685->cur_mode->reg_list);
-       if (ret)
+       if (ret) {
+               dev_err(dev, "Failed to set regs for power on\n");
                goto disable_supplies;
+       }
 
        return 0;