perf ftrace profile: Add -s/--sort option

The -s/--sort option is to sort the output by given column.

  $ sudo perf ftrace profile -s max sync | head
  # Total (us)   Avg (us)   Max (us)      Count   Function
      6301.811   6301.811   6301.811          1   __do_sys_sync
      6301.328   6301.328   6301.328          1   ksys_sync
      5320.300   1773.433   2858.819          3   iterate_supers
      2755.875     17.012   2610.633        162   sync_fs_one_sb
      2728.351    682.088   2610.413          4   ext4_sync_fs [ext4]
      2603.654   2603.654   2603.654          1   jbd2_log_wait_commit [jbd2]
      4750.615    593.827   2597.427          8   schedule
      2164.986     26.728   2115.673         81   sync_inodes_one_sb
      2143.842     26.467   2115.438         81   sync_inodes_sb

Reviewed-by: Ian Rogers <irogers@google.com>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Changbin Du <changbin.du@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
Link: https://lore.kernel.org/lkml/20240729004127.238611-5-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

diff --git a/tools/perf/Documentation/perf-ftrace.txt b/tools/perf/Documentation/perf-ftrace.txt
index 33f32467f287b619202834373f631443c04a55c3..eaec8253be681a0e3c6148ed2bb83b387f5ec18c 100644 (file)
--- a/tools/perf/Documentation/perf-ftrace.txt
+++ b/tools/perf/Documentation/perf-ftrace.txt
@@ -185,6 +185,11 @@ OPTIONS for 'perf ftrace profile'
        Set the size of per-cpu tracing buffer, <size> is expected to
        be a number with appended unit character - B/K/M/G.
 
+-s::
+--sort=::
+       Sort the result by the given field.  Available values are:
+       total, avg, max, count, name.  Default is 'total'.
+
 
 SEE ALSO
 --------

diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index ae9389435d1bb6c74be4fa056435c8fd58bab0df..a615c405d98f73c1f822ab16ad1c51a97d1268b8 100644 (file)
--- a/tools/perf/builtin-ftrace.c
+++ b/tools/perf/builtin-ftrace.c
@@ -1090,15 +1090,47 @@ static int parse_func_duration(struct perf_ftrace *ftrace, char *line, size_t le
        return add_func_duration(ftrace, func, duration);
 }
 
+enum perf_ftrace_profile_sort_key {
+       PFP_SORT_TOTAL = 0,
+       PFP_SORT_AVG,
+       PFP_SORT_MAX,
+       PFP_SORT_COUNT,
+       PFP_SORT_NAME,
+};
+
+static enum perf_ftrace_profile_sort_key profile_sort = PFP_SORT_TOTAL;
+
 static int cmp_profile_data(const void *a, const void *b)
 {
        const struct hashmap_entry *e1 = *(const struct hashmap_entry **)a;
        const struct hashmap_entry *e2 = *(const struct hashmap_entry **)b;
        struct ftrace_profile_data *p1 = e1->pvalue;
        struct ftrace_profile_data *p2 = e2->pvalue;
+       double v1, v2;
+
+       switch (profile_sort) {
+       case PFP_SORT_NAME:
+               return strcmp(e1->pkey, e2->pkey);
+       case PFP_SORT_AVG:
+               v1 = p1->st.mean;
+               v2 = p2->st.mean;
+               break;
+       case PFP_SORT_MAX:
+               v1 = p1->st.max;
+               v2 = p2->st.max;
+               break;
+       case PFP_SORT_COUNT:
+               v1 = p1->st.n;
+               v2 = p2->st.n;
+               break;
+       case PFP_SORT_TOTAL:
+       default:
+               v1 = p1->st.n * p1->st.mean;
+               v2 = p2->st.n * p2->st.mean;
+               break;
+       }
 
-       /* compare by total time */
-       if ((p1->st.n * p1->st.mean) > (p2->st.n * p2->st.mean))
+       if (v1 > v2)
                return -1;
        else
                return 1;
@@ -1414,6 +1446,30 @@ static int parse_graph_tracer_opts(const struct option *opt,
        return 0;
 }
 
+static int parse_sort_key(const struct option *opt, const char *str, int unset)
+{
+       enum perf_ftrace_profile_sort_key *key = (void *)opt->value;
+
+       if (unset)
+               return 0;
+
+       if (!strcmp(str, "total"))
+               *key = PFP_SORT_TOTAL;
+       else if (!strcmp(str, "avg"))
+               *key = PFP_SORT_AVG;
+       else if (!strcmp(str, "max"))
+               *key = PFP_SORT_MAX;
+       else if (!strcmp(str, "count"))
+               *key = PFP_SORT_COUNT;
+       else if (!strcmp(str, "name"))
+               *key = PFP_SORT_NAME;
+       else {
+               pr_err("Unknown sort key: %s\n", str);
+               return -1;
+       }
+       return 0;
+}
+
 enum perf_ftrace_subcommand {
        PERF_FTRACE_NONE,
        PERF_FTRACE_TRACE,
@@ -1497,6 +1553,9 @@ int cmd_ftrace(int argc, const char **argv)
                     "Set nograph filter on given functions", parse_filter_func),
        OPT_CALLBACK('m', "buffer-size", &ftrace.percpu_buffer_size, "size",
                     "Size of per cpu buffer, needs to use a B, K, M or G suffix.", parse_buffer_size),
+       OPT_CALLBACK('s', "sort", &profile_sort, "key",
+                    "Sort result by key: total (default), avg, max, count, name.",
+                    parse_sort_key),
        OPT_PARENT(common_options),
        };
        const struct option *options = ftrace_options;