sonypi: Use str_on_off() helper in sonypi_display_info()
authorThorsten Blum <thorsten.blum@linux.dev>
Mon, 10 Feb 2025 12:31:03 +0000 (13:31 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 20 Feb 2025 14:25:09 +0000 (15:25 +0100)
Remove hard-coded strings by using the str_on_off() helper function.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Link: https://lore.kernel.org/r/20250210123103.112938-2-thorsten.blum@linux.dev
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/sonypi.c

index f887569fd3d0f0e9102a69692df519dd30a43976..677bb5ac950a70336e1d06626258f7a3f04c7a2a 100644 (file)
@@ -37,6 +37,7 @@
 #include <linux/kfifo.h>
 #include <linux/platform_device.h>
 #include <linux/gfp.h>
+#include <linux/string_choices.h>
 
 #include <linux/uaccess.h>
 #include <asm/io.h>
@@ -1268,12 +1269,12 @@ static void sonypi_display_info(void)
               "compat = %s, mask = 0x%08lx, useinput = %s, acpi = %s\n",
               sonypi_device.model,
               verbose,
-              fnkeyinit ? "on" : "off",
-              camera ? "on" : "off",
-              compat ? "on" : "off",
+              str_on_off(fnkeyinit),
+              str_on_off(camera),
+              str_on_off(compat),
               mask,
-              useinput ? "on" : "off",
-              SONYPI_ACPI_ACTIVE ? "on" : "off");
+              str_on_off(useinput),
+              str_on_off(SONYPI_ACPI_ACTIVE));
        printk(KERN_INFO "sonypi: enabled at irq=%d, port1=0x%x, port2=0x%x\n",
               sonypi_device.irq,
               sonypi_device.ioport1, sonypi_device.ioport2);