selftests: bpf: break up test_progs - pkt access
authorStanislav Fomichev <sdf@google.com>
Sat, 2 Mar 2019 03:42:14 +0000 (19:42 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Sat, 2 Mar 2019 19:10:40 +0000 (11:10 -0800)
Move pkt access prog tests into separate files.

Signed-off-by: Stanislav Fomichev <sdf@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/prog_tests/pkt_access.c [new file with mode: 0644]
tools/testing/selftests/bpf/prog_tests/pkt_md_access.c [new file with mode: 0644]
tools/testing/selftests/bpf/test_progs.c

diff --git a/tools/testing/selftests/bpf/prog_tests/pkt_access.c b/tools/testing/selftests/bpf/prog_tests/pkt_access.c
new file mode 100644 (file)
index 0000000..4ecfd72
--- /dev/null
@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: GPL-2.0
+#include <test_progs.h>
+
+void test_pkt_access(void)
+{
+       const char *file = "./test_pkt_access.o";
+       struct bpf_object *obj;
+       __u32 duration, retval;
+       int err, prog_fd;
+
+       err = bpf_prog_load(file, BPF_PROG_TYPE_SCHED_CLS, &obj, &prog_fd);
+       if (err) {
+               error_cnt++;
+               return;
+       }
+
+       err = bpf_prog_test_run(prog_fd, 100000, &pkt_v4, sizeof(pkt_v4),
+                               NULL, NULL, &retval, &duration);
+       CHECK(err || retval, "ipv4",
+             "err %d errno %d retval %d duration %d\n",
+             err, errno, retval, duration);
+
+       err = bpf_prog_test_run(prog_fd, 100000, &pkt_v6, sizeof(pkt_v6),
+                               NULL, NULL, &retval, &duration);
+       CHECK(err || retval, "ipv6",
+             "err %d errno %d retval %d duration %d\n",
+             err, errno, retval, duration);
+       bpf_object__close(obj);
+}
diff --git a/tools/testing/selftests/bpf/prog_tests/pkt_md_access.c b/tools/testing/selftests/bpf/prog_tests/pkt_md_access.c
new file mode 100644 (file)
index 0000000..ac0d434
--- /dev/null
@@ -0,0 +1,24 @@
+// SPDX-License-Identifier: GPL-2.0
+#include <test_progs.h>
+
+void test_pkt_md_access(void)
+{
+       const char *file = "./test_pkt_md_access.o";
+       struct bpf_object *obj;
+       __u32 duration, retval;
+       int err, prog_fd;
+
+       err = bpf_prog_load(file, BPF_PROG_TYPE_SCHED_CLS, &obj, &prog_fd);
+       if (err) {
+               error_cnt++;
+               return;
+       }
+
+       err = bpf_prog_test_run(prog_fd, 10, &pkt_v4, sizeof(pkt_v4),
+                               NULL, NULL, &retval, &duration);
+       CHECK(err || retval, "",
+             "err %d errno %d retval %d duration %d\n",
+             err, errno, retval, duration);
+
+       bpf_object__close(obj);
+}
index e3f74fb617c127ed798931d68d5c00b34c020349..4f57096157492dbf283e30541c1aa5f5ede939e1 100644 (file)
@@ -40,33 +40,6 @@ int bpf_find_map(const char *test, struct bpf_object *obj, const char *name)
        return bpf_map__fd(map);
 }
 
-static void test_pkt_access(void)
-{
-       const char *file = "./test_pkt_access.o";
-       struct bpf_object *obj;
-       __u32 duration, retval;
-       int err, prog_fd;
-
-       err = bpf_prog_load(file, BPF_PROG_TYPE_SCHED_CLS, &obj, &prog_fd);
-       if (err) {
-               error_cnt++;
-               return;
-       }
-
-       err = bpf_prog_test_run(prog_fd, 100000, &pkt_v4, sizeof(pkt_v4),
-                               NULL, NULL, &retval, &duration);
-       CHECK(err || retval, "ipv4",
-             "err %d errno %d retval %d duration %d\n",
-             err, errno, retval, duration);
-
-       err = bpf_prog_test_run(prog_fd, 100000, &pkt_v6, sizeof(pkt_v6),
-                               NULL, NULL, &retval, &duration);
-       CHECK(err || retval, "ipv6",
-             "err %d errno %d retval %d duration %d\n",
-             err, errno, retval, duration);
-       bpf_object__close(obj);
-}
-
 static void test_prog_run_xattr(void)
 {
        const char *file = "./test_pkt_access.o";
@@ -648,28 +621,6 @@ done:
                bpf_object__close(objs[i]);
 }
 
-static void test_pkt_md_access(void)
-{
-       const char *file = "./test_pkt_md_access.o";
-       struct bpf_object *obj;
-       __u32 duration, retval;
-       int err, prog_fd;
-
-       err = bpf_prog_load(file, BPF_PROG_TYPE_SCHED_CLS, &obj, &prog_fd);
-       if (err) {
-               error_cnt++;
-               return;
-       }
-
-       err = bpf_prog_test_run(prog_fd, 10, &pkt_v4, sizeof(pkt_v4),
-                               NULL, NULL, &retval, &duration);
-       CHECK(err || retval, "",
-             "err %d errno %d retval %d duration %d\n",
-             err, errno, retval, duration);
-
-       bpf_object__close(obj);
-}
-
 static void test_obj_name(void)
 {
        struct {
@@ -2095,7 +2046,6 @@ int main(void)
 #define CALL
 #include <prog_tests/tests.h>
 #undef CALL
-       test_pkt_access();
        test_prog_run_xattr();
        test_xdp();
        test_xdp_adjust_tail();
@@ -2103,7 +2053,6 @@ int main(void)
        test_xdp_noinline();
        test_tcp_estats();
        test_bpf_obj_id();
-       test_pkt_md_access();
        test_obj_name();
        test_tp_attach_query();
        test_stacktrace_map();