wifi: ath12k: dp_mon: Fix unsigned comparison with less than zero
authorYang Li <yang.lee@linux.alibaba.com>
Wed, 15 Feb 2023 18:31:37 +0000 (20:31 +0200)
committerKalle Valo <quic_kvalo@quicinc.com>
Fri, 17 Feb 2023 16:09:12 +0000 (18:09 +0200)
The return value from the call to idr_alloc() is int.
However, the return value is being assigned to an unsigned
int variable 'buf_id', so making 'buf_id' an int.

Eliminate the following warning:
./drivers/net/wireless/ath/ath12k/dp_mon.c:1300:15-21: WARNING: Unsigned expression compared with zero: buf_id < 0

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4060
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230215011453.73466-1-yang.lee@linux.alibaba.com
drivers/net/wireless/ath/ath12k/dp_mon.c

index 4f93e4c95fed24e3f8407d2d042e71271fde5009..85f8f802340ddc026c5e99c276527f2776ca8c70 100644 (file)
@@ -1268,7 +1268,8 @@ int ath12k_dp_mon_buf_replenish(struct ath12k_base *ab,
        struct sk_buff *skb;
        struct hal_srng *srng;
        dma_addr_t paddr;
-       u32 cookie, buf_id;
+       u32 cookie;
+       int buf_id;
 
        srng = &ab->hal.srng_list[buf_ring->refill_buf_ring.ring_id];
        spin_lock_bh(&srng->lock);