tty: evh_bytechan: Replace NO_IRQ by 0
authorChristophe Leroy <christophe.leroy@csgroup.eu>
Thu, 6 Oct 2022 05:20:52 +0000 (07:20 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 2 Nov 2022 07:10:42 +0000 (08:10 +0100)
NO_IRQ is used to check the return of irq_of_parse_and_map().

On some architecture NO_IRQ is 0, on other architectures it is -1.

irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.

So use 0 instead of using NO_IRQ.

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
Acked-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Link: https://lore.kernel.org/r/23f608ca57e7e19bc7060d3e563de383e0b2b337.1665033575.git.christophe.leroy@csgroup.eu
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/ehv_bytechan.c

index 19d32cb6af84e30101b5bb54ee20b4faa4b230a8..8595483f4697751fb1ffcb203d3ad3b9711988d5 100644 (file)
@@ -118,7 +118,7 @@ static int find_console_handle(void)
                return 0;
 
        stdout_irq = irq_of_parse_and_map(np, 0);
-       if (stdout_irq == NO_IRQ) {
+       if (!stdout_irq) {
                pr_err("ehv-bc: no 'interrupts' property in %pOF node\n", np);
                return 0;
        }
@@ -696,7 +696,7 @@ static int ehv_bc_tty_probe(struct platform_device *pdev)
 
        bc->rx_irq = irq_of_parse_and_map(np, 0);
        bc->tx_irq = irq_of_parse_and_map(np, 1);
-       if ((bc->rx_irq == NO_IRQ) || (bc->tx_irq == NO_IRQ)) {
+       if (!bc->rx_irq || !bc->tx_irq) {
                dev_err(&pdev->dev, "no 'interrupts' property in %pOFn node\n",
                        np);
                ret = -ENODEV;