i2c: dev: don't start function name with 'return'
authorWolfram Sang <wsa@the-dreams.de>
Fri, 27 May 2016 11:13:01 +0000 (13:13 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Fri, 27 May 2016 11:13:01 +0000 (13:13 +0200)
I stumbled multiple times over 'return_i2c_dev', especially before the
actual 'return res'. It makes the code hard to read, so reanme the
function to 'put_i2c_dev' which also better matches 'get_free_i2c_dev'.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/i2c-dev.c

index 2562a45ff152e58ce85ea3cf27c56aafa320e1c7..89593dcb79f0327f7ba3c2f3092ee51cefe1551d 100644 (file)
@@ -91,7 +91,7 @@ static struct i2c_dev *get_free_i2c_dev(struct i2c_adapter *adap)
        return i2c_dev;
 }
 
-static void return_i2c_dev(struct i2c_dev *i2c_dev)
+static void put_i2c_dev(struct i2c_dev *i2c_dev)
 {
        spin_lock(&i2c_dev_list_lock);
        list_del(&i2c_dev->list);
@@ -575,7 +575,7 @@ static int i2cdev_attach_adapter(struct device *dev, void *dummy)
 error:
        cdev_del(&i2c_dev->cdev);
 error_cdev:
-       return_i2c_dev(i2c_dev);
+       put_i2c_dev(i2c_dev);
        return res;
 }
 
@@ -592,7 +592,7 @@ static int i2cdev_detach_adapter(struct device *dev, void *dummy)
        if (!i2c_dev) /* attach_adapter must have failed */
                return 0;
 
-       return_i2c_dev(i2c_dev);
+       put_i2c_dev(i2c_dev);
        device_destroy(i2c_dev_class, MKDEV(I2C_MAJOR, adap->nr));
        cdev_del(&i2c_dev->cdev);