USB: cdc-acm: Fill in Renesas R-Car D3 USB Download mode quirk
authorMarek Vasut <marek.vasut+renesas@mailbox.org>
Sun, 9 Feb 2025 14:56:11 +0000 (15:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Feb 2025 08:22:36 +0000 (09:22 +0100)
Add Renesas R-Car D3 USB Download mode quirk and update comments
on all the other Renesas R-Car USB Download mode quirks to discern
them from each other. This follows R-Car Series, 3rd Generation
reference manual Rev.2.00 chapter 19.2.8 USB download mode .

Fixes: 6d853c9e4104 ("usb: cdc-acm: Add DISABLE_ECHO for Renesas USB Download mode")
Cc: stable <stable@kernel.org>
Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20250209145708.106914-1-marek.vasut+renesas@mailbox.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/class/cdc-acm.c

index c70f349936238595cbb3a5c9b049a2b5acf8c07b..c2ecfa3c83496fcbd97af815c500f2d4044a36ca 100644 (file)
@@ -1738,13 +1738,16 @@ static const struct usb_device_id acm_ids[] = {
        { USB_DEVICE(0x0870, 0x0001), /* Metricom GS Modem */
        .driver_info = NO_UNION_NORMAL, /* has no union descriptor */
        },
-       { USB_DEVICE(0x045b, 0x023c),   /* Renesas USB Download mode */
+       { USB_DEVICE(0x045b, 0x023c),   /* Renesas R-Car H3 USB Download mode */
        .driver_info = DISABLE_ECHO,    /* Don't echo banner */
        },
-       { USB_DEVICE(0x045b, 0x0248),   /* Renesas USB Download mode */
+       { USB_DEVICE(0x045b, 0x0247),   /* Renesas R-Car D3 USB Download mode */
        .driver_info = DISABLE_ECHO,    /* Don't echo banner */
        },
-       { USB_DEVICE(0x045b, 0x024D),   /* Renesas USB Download mode */
+       { USB_DEVICE(0x045b, 0x0248),   /* Renesas R-Car M3-N USB Download mode */
+       .driver_info = DISABLE_ECHO,    /* Don't echo banner */
+       },
+       { USB_DEVICE(0x045b, 0x024D),   /* Renesas R-Car E3 USB Download mode */
        .driver_info = DISABLE_ECHO,    /* Don't echo banner */
        },
        { USB_DEVICE(0x0e8d, 0x0003), /* FIREFLY, MediaTek Inc; andrey.arapov@gmail.com */