drm/meson: rename venc_cvbs to encoder_cvbs
authorNeil Armstrong <narmstrong@baylibre.com>
Wed, 20 Oct 2021 12:39:46 +0000 (14:39 +0200)
committerNeil Armstrong <narmstrong@baylibre.com>
Fri, 12 Nov 2021 09:10:01 +0000 (10:10 +0100)
Rename the cvbs encoder to match the newly introduced meson_encoder_hdmi.

Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211020123947.2585572-6-narmstrong@baylibre.com
drivers/gpu/drm/meson/Makefile
drivers/gpu/drm/meson/meson_drv.c
drivers/gpu/drm/meson/meson_encoder_cvbs.c [new file with mode: 0644]
drivers/gpu/drm/meson/meson_encoder_cvbs.h [new file with mode: 0644]
drivers/gpu/drm/meson/meson_venc_cvbs.c [deleted file]
drivers/gpu/drm/meson/meson_venc_cvbs.h [deleted file]

index 523fce45f16ba75f0a39487018db9033dcdbd4af..3afa31bdc95014907fe5775b06f83469810352de 100644 (file)
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
-meson-drm-y := meson_drv.o meson_plane.o meson_crtc.o meson_venc_cvbs.o
+meson-drm-y := meson_drv.o meson_plane.o meson_crtc.o meson_encoder_cvbs.o
 meson-drm-y += meson_viu.o meson_vpp.o meson_venc.o meson_vclk.o meson_overlay.o
 meson-drm-y += meson_rdma.o meson_osd_afbcd.o
 meson-drm-y += meson_encoder_hdmi.o
index 0978b440f336d67b8ea2d763669b7a4c08f05516..80f1d439841a63029ed40ec9013b83e95151546d 100644 (file)
@@ -31,7 +31,7 @@
 #include "meson_plane.h"
 #include "meson_osd_afbcd.h"
 #include "meson_registers.h"
-#include "meson_venc_cvbs.h"
+#include "meson_encoder_cvbs.h"
 #include "meson_encoder_hdmi.h"
 #include "meson_viu.h"
 #include "meson_vpp.h"
@@ -307,7 +307,7 @@ static int meson_drv_bind_master(struct device *dev, bool has_components)
 
        /* Encoder Initialization */
 
-       ret = meson_venc_cvbs_create(priv);
+       ret = meson_encoder_cvbs_init(priv);
        if (ret)
                goto free_drm;
 
diff --git a/drivers/gpu/drm/meson/meson_encoder_cvbs.c b/drivers/gpu/drm/meson/meson_encoder_cvbs.c
new file mode 100644 (file)
index 0000000..01024c5
--- /dev/null
@@ -0,0 +1,293 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (C) 2016 BayLibre, SAS
+ * Author: Neil Armstrong <narmstrong@baylibre.com>
+ * Copyright (C) 2015 Amlogic, Inc. All rights reserved.
+ * Copyright (C) 2014 Endless Mobile
+ *
+ * Written by:
+ *     Jasper St. Pierre <jstpierre@mecheye.net>
+ */
+
+#include <linux/export.h>
+#include <linux/of_graph.h>
+
+#include <drm/drm_atomic_helper.h>
+#include <drm/drm_device.h>
+#include <drm/drm_edid.h>
+#include <drm/drm_probe_helper.h>
+#include <drm/drm_print.h>
+
+#include "meson_registers.h"
+#include "meson_vclk.h"
+#include "meson_encoder_cvbs.h"
+
+/* HHI VDAC Registers */
+#define HHI_VDAC_CNTL0         0x2F4 /* 0xbd offset in data sheet */
+#define HHI_VDAC_CNTL0_G12A    0x2EC /* 0xbd offset in data sheet */
+#define HHI_VDAC_CNTL1         0x2F8 /* 0xbe offset in data sheet */
+#define HHI_VDAC_CNTL1_G12A    0x2F0 /* 0xbe offset in data sheet */
+
+struct meson_encoder_cvbs {
+       struct drm_encoder      encoder;
+       struct drm_connector    connector;
+       struct meson_drm        *priv;
+};
+#define encoder_to_meson_encoder_cvbs(x) \
+       container_of(x, struct meson_encoder_cvbs, encoder)
+
+#define connector_to_meson_encoder_cvbs(x) \
+       container_of(x, struct meson_encoder_cvbs, connector)
+
+/* Supported Modes */
+
+struct meson_cvbs_mode meson_cvbs_modes[MESON_CVBS_MODES_COUNT] = {
+       { /* PAL */
+               .enci = &meson_cvbs_enci_pal,
+               .mode = {
+                       DRM_MODE("720x576i", DRM_MODE_TYPE_DRIVER, 13500,
+                                720, 732, 795, 864, 0, 576, 580, 586, 625, 0,
+                                DRM_MODE_FLAG_INTERLACE),
+                       .picture_aspect_ratio = HDMI_PICTURE_ASPECT_4_3,
+               },
+       },
+       { /* NTSC */
+               .enci = &meson_cvbs_enci_ntsc,
+               .mode = {
+                       DRM_MODE("720x480i", DRM_MODE_TYPE_DRIVER, 13500,
+                               720, 739, 801, 858, 0, 480, 488, 494, 525, 0,
+                               DRM_MODE_FLAG_INTERLACE),
+                       .picture_aspect_ratio = HDMI_PICTURE_ASPECT_4_3,
+               },
+       },
+};
+
+static const struct meson_cvbs_mode *
+meson_cvbs_get_mode(const struct drm_display_mode *req_mode)
+{
+       int i;
+
+       for (i = 0; i < MESON_CVBS_MODES_COUNT; ++i) {
+               struct meson_cvbs_mode *meson_mode = &meson_cvbs_modes[i];
+
+               if (drm_mode_match(req_mode, &meson_mode->mode,
+                                  DRM_MODE_MATCH_TIMINGS |
+                                  DRM_MODE_MATCH_CLOCK |
+                                  DRM_MODE_MATCH_FLAGS |
+                                  DRM_MODE_MATCH_3D_FLAGS))
+                       return meson_mode;
+       }
+
+       return NULL;
+}
+
+/* Connector */
+
+static void meson_cvbs_connector_destroy(struct drm_connector *connector)
+{
+       drm_connector_cleanup(connector);
+}
+
+static enum drm_connector_status
+meson_cvbs_connector_detect(struct drm_connector *connector, bool force)
+{
+       /* FIXME: Add load-detect or jack-detect if possible */
+       return connector_status_connected;
+}
+
+static int meson_cvbs_connector_get_modes(struct drm_connector *connector)
+{
+       struct drm_device *dev = connector->dev;
+       struct drm_display_mode *mode;
+       int i;
+
+       for (i = 0; i < MESON_CVBS_MODES_COUNT; ++i) {
+               struct meson_cvbs_mode *meson_mode = &meson_cvbs_modes[i];
+
+               mode = drm_mode_duplicate(dev, &meson_mode->mode);
+               if (!mode) {
+                       DRM_ERROR("Failed to create a new display mode\n");
+                       return 0;
+               }
+
+               drm_mode_probed_add(connector, mode);
+       }
+
+       return i;
+}
+
+static int meson_cvbs_connector_mode_valid(struct drm_connector *connector,
+                                          struct drm_display_mode *mode)
+{
+       /* Validate the modes added in get_modes */
+       return MODE_OK;
+}
+
+static const struct drm_connector_funcs meson_cvbs_connector_funcs = {
+       .detect                 = meson_cvbs_connector_detect,
+       .fill_modes             = drm_helper_probe_single_connector_modes,
+       .destroy                = meson_cvbs_connector_destroy,
+       .reset                  = drm_atomic_helper_connector_reset,
+       .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
+       .atomic_destroy_state   = drm_atomic_helper_connector_destroy_state,
+};
+
+static const
+struct drm_connector_helper_funcs meson_cvbs_connector_helper_funcs = {
+       .get_modes      = meson_cvbs_connector_get_modes,
+       .mode_valid     = meson_cvbs_connector_mode_valid,
+};
+
+/* Encoder */
+
+static void meson_encoder_cvbs_encoder_destroy(struct drm_encoder *encoder)
+{
+       drm_encoder_cleanup(encoder);
+}
+
+static const struct drm_encoder_funcs meson_encoder_cvbs_encoder_funcs = {
+       .destroy        = meson_encoder_cvbs_encoder_destroy,
+};
+
+static int meson_encoder_cvbs_encoder_atomic_check(struct drm_encoder *encoder,
+                                       struct drm_crtc_state *crtc_state,
+                                       struct drm_connector_state *conn_state)
+{
+       if (meson_cvbs_get_mode(&crtc_state->mode))
+               return 0;
+
+       return -EINVAL;
+}
+
+static void meson_encoder_cvbs_encoder_disable(struct drm_encoder *encoder)
+{
+       struct meson_encoder_cvbs *meson_encoder_cvbs =
+                                       encoder_to_meson_encoder_cvbs(encoder);
+       struct meson_drm *priv = meson_encoder_cvbs->priv;
+
+       /* Disable CVBS VDAC */
+       if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_G12A)) {
+               regmap_write(priv->hhi, HHI_VDAC_CNTL0_G12A, 0);
+               regmap_write(priv->hhi, HHI_VDAC_CNTL1_G12A, 0);
+       } else {
+               regmap_write(priv->hhi, HHI_VDAC_CNTL0, 0);
+               regmap_write(priv->hhi, HHI_VDAC_CNTL1, 8);
+       }
+}
+
+static void meson_encoder_cvbs_encoder_enable(struct drm_encoder *encoder)
+{
+       struct meson_encoder_cvbs *meson_encoder_cvbs =
+                                       encoder_to_meson_encoder_cvbs(encoder);
+       struct meson_drm *priv = meson_encoder_cvbs->priv;
+
+       /* VDAC0 source is not from ATV */
+       writel_bits_relaxed(VENC_VDAC_SEL_ATV_DMD, 0,
+                           priv->io_base + _REG(VENC_VDAC_DACSEL0));
+
+       if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_GXBB)) {
+               regmap_write(priv->hhi, HHI_VDAC_CNTL0, 1);
+               regmap_write(priv->hhi, HHI_VDAC_CNTL1, 0);
+       } else if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_GXM) ||
+                meson_vpu_is_compatible(priv, VPU_COMPATIBLE_GXL)) {
+               regmap_write(priv->hhi, HHI_VDAC_CNTL0, 0xf0001);
+               regmap_write(priv->hhi, HHI_VDAC_CNTL1, 0);
+       } else if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_G12A)) {
+               regmap_write(priv->hhi, HHI_VDAC_CNTL0_G12A, 0x906001);
+               regmap_write(priv->hhi, HHI_VDAC_CNTL1_G12A, 0);
+       }
+}
+
+static void meson_encoder_cvbs_encoder_mode_set(struct drm_encoder *encoder,
+                                  struct drm_display_mode *mode,
+                                  struct drm_display_mode *adjusted_mode)
+{
+       const struct meson_cvbs_mode *meson_mode = meson_cvbs_get_mode(mode);
+       struct meson_encoder_cvbs *meson_encoder_cvbs =
+                                       encoder_to_meson_encoder_cvbs(encoder);
+       struct meson_drm *priv = meson_encoder_cvbs->priv;
+
+       if (meson_mode) {
+               meson_venci_cvbs_mode_set(priv, meson_mode->enci);
+
+               /* Setup 27MHz vclk2 for ENCI and VDAC */
+               meson_vclk_setup(priv, MESON_VCLK_TARGET_CVBS,
+                                MESON_VCLK_CVBS, MESON_VCLK_CVBS,
+                                MESON_VCLK_CVBS, MESON_VCLK_CVBS,
+                                true);
+       }
+}
+
+static const struct drm_encoder_helper_funcs
+                               meson_encoder_cvbs_encoder_helper_funcs = {
+       .atomic_check   = meson_encoder_cvbs_encoder_atomic_check,
+       .disable        = meson_encoder_cvbs_encoder_disable,
+       .enable         = meson_encoder_cvbs_encoder_enable,
+       .mode_set       = meson_encoder_cvbs_encoder_mode_set,
+};
+
+static bool meson_encoder_cvbs_connector_is_available(struct meson_drm *priv)
+{
+       struct device_node *remote;
+
+       remote = of_graph_get_remote_node(priv->dev->of_node, 0, 0);
+       if (!remote)
+               return false;
+
+       of_node_put(remote);
+       return true;
+}
+
+int meson_encoder_cvbs_init(struct meson_drm *priv)
+{
+       struct drm_device *drm = priv->drm;
+       struct meson_encoder_cvbs *meson_encoder_cvbs;
+       struct drm_connector *connector;
+       struct drm_encoder *encoder;
+       int ret;
+
+       if (!meson_encoder_cvbs_connector_is_available(priv)) {
+               dev_info(drm->dev, "CVBS Output connector not available\n");
+               return 0;
+       }
+
+       meson_encoder_cvbs = devm_kzalloc(priv->dev, sizeof(*meson_encoder_cvbs),
+                                      GFP_KERNEL);
+       if (!meson_encoder_cvbs)
+               return -ENOMEM;
+
+       meson_encoder_cvbs->priv = priv;
+       encoder = &meson_encoder_cvbs->encoder;
+       connector = &meson_encoder_cvbs->connector;
+
+       /* Connector */
+
+       drm_connector_helper_add(connector,
+                                &meson_cvbs_connector_helper_funcs);
+
+       ret = drm_connector_init(drm, connector, &meson_cvbs_connector_funcs,
+                                DRM_MODE_CONNECTOR_Composite);
+       if (ret) {
+               dev_err(priv->dev, "Failed to init CVBS connector\n");
+               return ret;
+       }
+
+       connector->interlace_allowed = 1;
+
+       /* Encoder */
+
+       drm_encoder_helper_add(encoder, &meson_encoder_cvbs_encoder_helper_funcs);
+
+       ret = drm_encoder_init(drm, encoder, &meson_encoder_cvbs_encoder_funcs,
+                              DRM_MODE_ENCODER_TVDAC, "meson_encoder_cvbs");
+       if (ret) {
+               dev_err(priv->dev, "Failed to init CVBS encoder\n");
+               return ret;
+       }
+
+       encoder->possible_crtcs = BIT(0);
+
+       drm_connector_attach_encoder(connector, encoder);
+
+       return 0;
+}
diff --git a/drivers/gpu/drm/meson/meson_encoder_cvbs.h b/drivers/gpu/drm/meson/meson_encoder_cvbs.h
new file mode 100644 (file)
index 0000000..61d9d18
--- /dev/null
@@ -0,0 +1,29 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Copyright (C) 2016 BayLibre, SAS
+ * Author: Neil Armstrong <narmstrong@baylibre.com>
+ * Copyright (C) 2014 Endless Mobile
+ *
+ * Written by:
+ *     Jasper St. Pierre <jstpierre@mecheye.net>
+ */
+
+#ifndef __MESON_VENC_CVBS_H
+#define __MESON_VENC_CVBS_H
+
+#include "meson_drv.h"
+#include "meson_venc.h"
+
+struct meson_cvbs_mode {
+       struct meson_cvbs_enci_mode *enci;
+       struct drm_display_mode mode;
+};
+
+#define MESON_CVBS_MODES_COUNT 2
+
+/* Modes supported by the CVBS output */
+extern struct meson_cvbs_mode meson_cvbs_modes[MESON_CVBS_MODES_COUNT];
+
+int meson_encoder_cvbs_init(struct meson_drm *priv);
+
+#endif /* __MESON_VENC_CVBS_H */
diff --git a/drivers/gpu/drm/meson/meson_venc_cvbs.c b/drivers/gpu/drm/meson/meson_venc_cvbs.c
deleted file mode 100644 (file)
index f1747fd..0000000
+++ /dev/null
@@ -1,293 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-or-later
-/*
- * Copyright (C) 2016 BayLibre, SAS
- * Author: Neil Armstrong <narmstrong@baylibre.com>
- * Copyright (C) 2015 Amlogic, Inc. All rights reserved.
- * Copyright (C) 2014 Endless Mobile
- *
- * Written by:
- *     Jasper St. Pierre <jstpierre@mecheye.net>
- */
-
-#include <linux/export.h>
-#include <linux/of_graph.h>
-
-#include <drm/drm_atomic_helper.h>
-#include <drm/drm_device.h>
-#include <drm/drm_edid.h>
-#include <drm/drm_probe_helper.h>
-#include <drm/drm_print.h>
-
-#include "meson_registers.h"
-#include "meson_vclk.h"
-#include "meson_venc_cvbs.h"
-
-/* HHI VDAC Registers */
-#define HHI_VDAC_CNTL0         0x2F4 /* 0xbd offset in data sheet */
-#define HHI_VDAC_CNTL0_G12A    0x2EC /* 0xbd offset in data sheet */
-#define HHI_VDAC_CNTL1         0x2F8 /* 0xbe offset in data sheet */
-#define HHI_VDAC_CNTL1_G12A    0x2F0 /* 0xbe offset in data sheet */
-
-struct meson_venc_cvbs {
-       struct drm_encoder      encoder;
-       struct drm_connector    connector;
-       struct meson_drm        *priv;
-};
-#define encoder_to_meson_venc_cvbs(x) \
-       container_of(x, struct meson_venc_cvbs, encoder)
-
-#define connector_to_meson_venc_cvbs(x) \
-       container_of(x, struct meson_venc_cvbs, connector)
-
-/* Supported Modes */
-
-struct meson_cvbs_mode meson_cvbs_modes[MESON_CVBS_MODES_COUNT] = {
-       { /* PAL */
-               .enci = &meson_cvbs_enci_pal,
-               .mode = {
-                       DRM_MODE("720x576i", DRM_MODE_TYPE_DRIVER, 13500,
-                                720, 732, 795, 864, 0, 576, 580, 586, 625, 0,
-                                DRM_MODE_FLAG_INTERLACE),
-                       .picture_aspect_ratio = HDMI_PICTURE_ASPECT_4_3,
-               },
-       },
-       { /* NTSC */
-               .enci = &meson_cvbs_enci_ntsc,
-               .mode = {
-                       DRM_MODE("720x480i", DRM_MODE_TYPE_DRIVER, 13500,
-                               720, 739, 801, 858, 0, 480, 488, 494, 525, 0,
-                               DRM_MODE_FLAG_INTERLACE),
-                       .picture_aspect_ratio = HDMI_PICTURE_ASPECT_4_3,
-               },
-       },
-};
-
-static const struct meson_cvbs_mode *
-meson_cvbs_get_mode(const struct drm_display_mode *req_mode)
-{
-       int i;
-
-       for (i = 0; i < MESON_CVBS_MODES_COUNT; ++i) {
-               struct meson_cvbs_mode *meson_mode = &meson_cvbs_modes[i];
-
-               if (drm_mode_match(req_mode, &meson_mode->mode,
-                                  DRM_MODE_MATCH_TIMINGS |
-                                  DRM_MODE_MATCH_CLOCK |
-                                  DRM_MODE_MATCH_FLAGS |
-                                  DRM_MODE_MATCH_3D_FLAGS))
-                       return meson_mode;
-       }
-
-       return NULL;
-}
-
-/* Connector */
-
-static void meson_cvbs_connector_destroy(struct drm_connector *connector)
-{
-       drm_connector_cleanup(connector);
-}
-
-static enum drm_connector_status
-meson_cvbs_connector_detect(struct drm_connector *connector, bool force)
-{
-       /* FIXME: Add load-detect or jack-detect if possible */
-       return connector_status_connected;
-}
-
-static int meson_cvbs_connector_get_modes(struct drm_connector *connector)
-{
-       struct drm_device *dev = connector->dev;
-       struct drm_display_mode *mode;
-       int i;
-
-       for (i = 0; i < MESON_CVBS_MODES_COUNT; ++i) {
-               struct meson_cvbs_mode *meson_mode = &meson_cvbs_modes[i];
-
-               mode = drm_mode_duplicate(dev, &meson_mode->mode);
-               if (!mode) {
-                       DRM_ERROR("Failed to create a new display mode\n");
-                       return 0;
-               }
-
-               drm_mode_probed_add(connector, mode);
-       }
-
-       return i;
-}
-
-static int meson_cvbs_connector_mode_valid(struct drm_connector *connector,
-                                          struct drm_display_mode *mode)
-{
-       /* Validate the modes added in get_modes */
-       return MODE_OK;
-}
-
-static const struct drm_connector_funcs meson_cvbs_connector_funcs = {
-       .detect                 = meson_cvbs_connector_detect,
-       .fill_modes             = drm_helper_probe_single_connector_modes,
-       .destroy                = meson_cvbs_connector_destroy,
-       .reset                  = drm_atomic_helper_connector_reset,
-       .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
-       .atomic_destroy_state   = drm_atomic_helper_connector_destroy_state,
-};
-
-static const
-struct drm_connector_helper_funcs meson_cvbs_connector_helper_funcs = {
-       .get_modes      = meson_cvbs_connector_get_modes,
-       .mode_valid     = meson_cvbs_connector_mode_valid,
-};
-
-/* Encoder */
-
-static void meson_venc_cvbs_encoder_destroy(struct drm_encoder *encoder)
-{
-       drm_encoder_cleanup(encoder);
-}
-
-static const struct drm_encoder_funcs meson_venc_cvbs_encoder_funcs = {
-       .destroy        = meson_venc_cvbs_encoder_destroy,
-};
-
-static int meson_venc_cvbs_encoder_atomic_check(struct drm_encoder *encoder,
-                                       struct drm_crtc_state *crtc_state,
-                                       struct drm_connector_state *conn_state)
-{
-       if (meson_cvbs_get_mode(&crtc_state->mode))
-               return 0;
-
-       return -EINVAL;
-}
-
-static void meson_venc_cvbs_encoder_disable(struct drm_encoder *encoder)
-{
-       struct meson_venc_cvbs *meson_venc_cvbs =
-                                       encoder_to_meson_venc_cvbs(encoder);
-       struct meson_drm *priv = meson_venc_cvbs->priv;
-
-       /* Disable CVBS VDAC */
-       if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_G12A)) {
-               regmap_write(priv->hhi, HHI_VDAC_CNTL0_G12A, 0);
-               regmap_write(priv->hhi, HHI_VDAC_CNTL1_G12A, 0);
-       } else {
-               regmap_write(priv->hhi, HHI_VDAC_CNTL0, 0);
-               regmap_write(priv->hhi, HHI_VDAC_CNTL1, 8);
-       }
-}
-
-static void meson_venc_cvbs_encoder_enable(struct drm_encoder *encoder)
-{
-       struct meson_venc_cvbs *meson_venc_cvbs =
-                                       encoder_to_meson_venc_cvbs(encoder);
-       struct meson_drm *priv = meson_venc_cvbs->priv;
-
-       /* VDAC0 source is not from ATV */
-       writel_bits_relaxed(VENC_VDAC_SEL_ATV_DMD, 0,
-                           priv->io_base + _REG(VENC_VDAC_DACSEL0));
-
-       if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_GXBB)) {
-               regmap_write(priv->hhi, HHI_VDAC_CNTL0, 1);
-               regmap_write(priv->hhi, HHI_VDAC_CNTL1, 0);
-       } else if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_GXM) ||
-                meson_vpu_is_compatible(priv, VPU_COMPATIBLE_GXL)) {
-               regmap_write(priv->hhi, HHI_VDAC_CNTL0, 0xf0001);
-               regmap_write(priv->hhi, HHI_VDAC_CNTL1, 0);
-       } else if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_G12A)) {
-               regmap_write(priv->hhi, HHI_VDAC_CNTL0_G12A, 0x906001);
-               regmap_write(priv->hhi, HHI_VDAC_CNTL1_G12A, 0);
-       }
-}
-
-static void meson_venc_cvbs_encoder_mode_set(struct drm_encoder *encoder,
-                                  struct drm_display_mode *mode,
-                                  struct drm_display_mode *adjusted_mode)
-{
-       const struct meson_cvbs_mode *meson_mode = meson_cvbs_get_mode(mode);
-       struct meson_venc_cvbs *meson_venc_cvbs =
-                                       encoder_to_meson_venc_cvbs(encoder);
-       struct meson_drm *priv = meson_venc_cvbs->priv;
-
-       if (meson_mode) {
-               meson_venci_cvbs_mode_set(priv, meson_mode->enci);
-
-               /* Setup 27MHz vclk2 for ENCI and VDAC */
-               meson_vclk_setup(priv, MESON_VCLK_TARGET_CVBS,
-                                MESON_VCLK_CVBS, MESON_VCLK_CVBS,
-                                MESON_VCLK_CVBS, MESON_VCLK_CVBS,
-                                true);
-       }
-}
-
-static const struct drm_encoder_helper_funcs
-                               meson_venc_cvbs_encoder_helper_funcs = {
-       .atomic_check   = meson_venc_cvbs_encoder_atomic_check,
-       .disable        = meson_venc_cvbs_encoder_disable,
-       .enable         = meson_venc_cvbs_encoder_enable,
-       .mode_set       = meson_venc_cvbs_encoder_mode_set,
-};
-
-static bool meson_venc_cvbs_connector_is_available(struct meson_drm *priv)
-{
-       struct device_node *remote;
-
-       remote = of_graph_get_remote_node(priv->dev->of_node, 0, 0);
-       if (!remote)
-               return false;
-
-       of_node_put(remote);
-       return true;
-}
-
-int meson_venc_cvbs_create(struct meson_drm *priv)
-{
-       struct drm_device *drm = priv->drm;
-       struct meson_venc_cvbs *meson_venc_cvbs;
-       struct drm_connector *connector;
-       struct drm_encoder *encoder;
-       int ret;
-
-       if (!meson_venc_cvbs_connector_is_available(priv)) {
-               dev_info(drm->dev, "CVBS Output connector not available\n");
-               return 0;
-       }
-
-       meson_venc_cvbs = devm_kzalloc(priv->dev, sizeof(*meson_venc_cvbs),
-                                      GFP_KERNEL);
-       if (!meson_venc_cvbs)
-               return -ENOMEM;
-
-       meson_venc_cvbs->priv = priv;
-       encoder = &meson_venc_cvbs->encoder;
-       connector = &meson_venc_cvbs->connector;
-
-       /* Connector */
-
-       drm_connector_helper_add(connector,
-                                &meson_cvbs_connector_helper_funcs);
-
-       ret = drm_connector_init(drm, connector, &meson_cvbs_connector_funcs,
-                                DRM_MODE_CONNECTOR_Composite);
-       if (ret) {
-               dev_err(priv->dev, "Failed to init CVBS connector\n");
-               return ret;
-       }
-
-       connector->interlace_allowed = 1;
-
-       /* Encoder */
-
-       drm_encoder_helper_add(encoder, &meson_venc_cvbs_encoder_helper_funcs);
-
-       ret = drm_encoder_init(drm, encoder, &meson_venc_cvbs_encoder_funcs,
-                              DRM_MODE_ENCODER_TVDAC, "meson_venc_cvbs");
-       if (ret) {
-               dev_err(priv->dev, "Failed to init CVBS encoder\n");
-               return ret;
-       }
-
-       encoder->possible_crtcs = BIT(0);
-
-       drm_connector_attach_encoder(connector, encoder);
-
-       return 0;
-}
diff --git a/drivers/gpu/drm/meson/meson_venc_cvbs.h b/drivers/gpu/drm/meson/meson_venc_cvbs.h
deleted file mode 100644 (file)
index ab7f76b..0000000
+++ /dev/null
@@ -1,29 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-or-later */
-/*
- * Copyright (C) 2016 BayLibre, SAS
- * Author: Neil Armstrong <narmstrong@baylibre.com>
- * Copyright (C) 2014 Endless Mobile
- *
- * Written by:
- *     Jasper St. Pierre <jstpierre@mecheye.net>
- */
-
-#ifndef __MESON_VENC_CVBS_H
-#define __MESON_VENC_CVBS_H
-
-#include "meson_drv.h"
-#include "meson_venc.h"
-
-struct meson_cvbs_mode {
-       struct meson_cvbs_enci_mode *enci;
-       struct drm_display_mode mode;
-};
-
-#define MESON_CVBS_MODES_COUNT 2
-
-/* Modes supported by the CVBS output */
-extern struct meson_cvbs_mode meson_cvbs_modes[MESON_CVBS_MODES_COUNT];
-
-int meson_venc_cvbs_create(struct meson_drm *priv);
-
-#endif /* __MESON_VENC_CVBS_H */