spi: spi-qpic-snand: propagate errors from qcom_spi_block_erase()
authorGabor Juhos <j4g8y7@gmail.com>
Wed, 23 Apr 2025 19:31:57 +0000 (21:31 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 24 Apr 2025 11:52:59 +0000 (12:52 +0100)
The qcom_spi_block_erase() function returns with error in case of
failure. Change the qcom_spi_send_cmdaddr() function to propagate
these errors to the callers instead of returning with success.

Fixes: 7304d1909080 ("spi: spi-qpic: add driver for QCOM SPI NAND flash Interface")
Signed-off-by: Gabor Juhos <j4g8y7@gmail.com>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://patch.msgid.link/20250423-qpic-snand-propagate-error-v1-1-4b26ed45fdb5@gmail.com
Reviewed-by: Md Sadre Alam <quic_mdalam@quicinc.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-qpic-snand.c

index 17eb67e19132612c4c1a84848fa6f7432b1130a8..ae32c452d0bcf852b69b76e595f3588ea7e1a670 100644 (file)
@@ -1307,8 +1307,7 @@ static int qcom_spi_send_cmdaddr(struct qcom_nand_controller *snandc,
                snandc->qspi->addr1 = cpu_to_le32(s_op.addr1_reg << 16);
                snandc->qspi->addr2 = cpu_to_le32(s_op.addr2_reg);
                snandc->qspi->cmd = cpu_to_le32(cmd);
-               qcom_spi_block_erase(snandc);
-               return 0;
+               return qcom_spi_block_erase(snandc);
        default:
                break;
        }