ethtool: ethnl_set_linkmodes: remove redundant null check

info cannot be NULL here since its being accessed earlier
in the function: nlmsg_parse(info->nlhdr...). Remove this
redundant NULL check.

Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
Reviewed-by: Michal Kubecek <mkubecek@suse.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/net/ethtool/linkmodes.c b/net/ethtool/linkmodes.c
index 317a93129551e9c9b209f77adecd83b7bf136b5c..7044a2853886d704b3015c640e7984d985c363f6 100644 (file)
--- a/net/ethtool/linkmodes.c
+++ b/net/ethtool/linkmodes.c
@@ -421,8 +421,7 @@ int ethnl_set_linkmodes(struct sk_buff *skb, struct genl_info *info)
 
        ret = __ethtool_get_link_ksettings(dev, &ksettings);
        if (ret < 0) {
-               if (info)
-                       GENL_SET_ERR_MSG(info, "failed to retrieve link settings");
+               GENL_SET_ERR_MSG(info, "failed to retrieve link settings");
                goto out_ops;
        }